refactor: replace sort.Slice with slices.Sort for natural ordering#4468
Open
findfluctuate wants to merge 1 commit into
Open
refactor: replace sort.Slice with slices.Sort for natural ordering#4468findfluctuate wants to merge 1 commit into
findfluctuate wants to merge 1 commit into
Conversation
Signed-off-by: findfluctuate <findfluctuate@outlook.com>
findfluctuate
requested review from
corverroos and
kevinhalliday
as code owners
|
@findfluctuate is attempting to deploy a commit to the nomina-eng Team on Vercel. A member of the Team first needs to authorize it. |
|
I made the same observation, but I saw that it has already been submitted. Hi, Could you please review this PR at your convenience? CC @kevinhalliday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
issue: none