Skip to content

[MIT-3611] Fix incorrect types and improve TypeScript examples#225

Merged
rosle merged 10 commits intomasterfrom
MIT-3611-improve-ts-examples-and-update-deps
Nov 11, 2025
Merged

[MIT-3611] Fix incorrect types and improve TypeScript examples#225
rosle merged 10 commits intomasterfrom
MIT-3611-improve-ts-examples-and-update-deps

Conversation

@rosle
Copy link
Copy Markdown
Contributor

@rosle rosle commented Nov 6, 2025

Description

Related links:

Rollback procedure

default rollback procedure

@rosle rosle self-assigned this Nov 6, 2025
@rosle rosle force-pushed the MIT-3611-improve-ts-examples-and-update-deps branch 2 times, most recently from e91b1b8 to ce67c68 Compare November 6, 2025 11:44
@rosle rosle force-pushed the MIT-3611-improve-ts-examples-and-update-deps branch from ce67c68 to 6589aa1 Compare November 6, 2025 11:50
@rosle rosle marked this pull request as ready for review November 7, 2025 06:48
@rosle rosle requested a review from Copilot November 10, 2025 03:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the omise-node library for version 1.0.0 release with several improvements including dependency updates, type definition enhancements, and reorganized TypeScript examples.

  • Updated mocha from 10.2.0 to 11.7.5 and removed deprecated tslint package
  • Enhanced TypeScript definitions to make card fields optional and add capture method overload
  • Reorganized TypeScript examples into a proper package structure with updated imports

Reviewed Changes

Copilot reviewed 32 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
types/index.d.ts Added capture method overload and made ICard fields (security_code, city, postal_code) optional for better API flexibility
package.json Updated mocha to 11.7.5, removed deprecated tslint, bumped version to 1.0.0
package-lock.json Updated lock file with new dependency versions including mocha 11.7.5 and transitive dependencies
tslint.json Removed deprecated tslint configuration file
tsconfig.json Cleaned up formatting by removing trailing whitespace
test/test_omise_host.js Improved test readability by renaming host from 'api.xxxxx.co' to 'api.wrong-host.co'
README.md Updated branding from "Opn Payment" to "Omise" and fixed contact email references throughout documentation
.github/workflows/coverage.yml Updated SonarCloud action reference and removed GITHUB_TOKEN environment variable
examples/typescript/tsconfig.json Added new TypeScript configuration for examples package
examples/typescript/package.json Created new package.json for TypeScript examples with proper dependencies
examples/typescript/package-lock.json Added lock file for TypeScript examples package
examples/typescript/.env.example Added environment variable template file
examples/typescript/src/*.ts Updated all example imports to use 'omise' package instead of relative paths
examples/typescript/src/create_customer.ts Fixed return type from ICustomerList to ICustomer
examples/typescript/src/capture_charge.ts Moved and updated capture charge example with proper imports
examples/typescript/capture_charge.ts Removed old file location
Files not reviewed (1)
  • examples/typescript/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/typescript/tsconfig.json Outdated
Comment thread .github/workflows/coverage.yml
Comment thread .github/workflows/coverage.yml
Comment thread README.md Outdated
@rosle rosle merged commit 4a6fe5e into master Nov 11, 2025
10 checks passed
@rosle rosle deleted the MIT-3611-improve-ts-examples-and-update-deps branch November 11, 2025 02:42
@rosle rosle mentioned this pull request Nov 24, 2025
rosle added a commit that referenced this pull request Nov 24, 2025
## Description

- #225 
- #226 

## Rollback procedure

`default rollback procedure`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants