Skip to content

fix(shared-browser): match workspaces by absolute directories only, and document path and mode behaviour - #640

Open
keithpk wants to merge 1 commit into
omercnet:mainfrom
keithpk:feat/shared-browser-follow-ups
Open

keithpk wants to merge 1 commit into
omercnet:mainfrom
keithpk:feat/shared-browser-follow-ups

Conversation

@keithpk

@keithpk keithpk commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Follow-ups to #637 that the review listed for a later PR.

What changes

  • A workspace directory that is not absolute after normalizing is skipped, and an agent directory must be absolute, so a relative directory such as . can no longer contain an absolute one.
  • README: backslash and UNC paths are only modelled as drive paths, and a literal backslash in a POSIX directory name counts as a separator.
  • README: changing the mode also saves the typed lists.
  • Test: a settings read that rejects after its timeout has fired leaves no unhandled rejection.

Checks

  • npm run test:unit: 864 passed, 6 skipped.
  • tsc --noEmit and biome check on the touched files are clean.
  • New tests cover the relative-directory cases and the late rejection.

Not done

  • The live check of includeBackground on Paseo 0.13 was not run. It is covered by tests only.

This touches the same files as #639 (labels), so whichever merges second will need a small rebase.

…nd document path and mode behaviour

Skip a workspace directory that is not absolute after normalizing and require an absolute agent directory, so a relative directory such as "." can no longer contain an absolute one. State in the README that backslash and UNC paths are only modelled as drive paths and that a literal backslash in a POSIX name counts as a separator, and that a mode change also saves the typed lists. Add a test that a settings read rejecting after its timeout fired leaves no unhandled rejection.
@baz-reviewer

baz-reviewer Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Restrict workspace matching to normalized absolute directories and document path, separator, and settings-mode behavior. Update workspacesForDirectory and isAbsoluteDirectory to prevent relative-path matches, while hardening timed settings reads against late unhandled rejections.

Topics

TopicDetails
Settings behavior Ensure timed-out settings reads safely absorb late rejections, and document that changing mode saves typed lists and reports parsing errors.
Modified files (2)
  • paseo-shared-browser/README.md
  • paseo-shared-browser/tests/contracts.test.ts
Latest Contributors(0)
UserCommitDate
Absolute path matching Restrict workspace and agent directory matching to normalized absolute paths, covering POSIX and drive roots while rejecting relative directories and documenting path semantics.
Modified files (3)
  • paseo-shared-browser/README.md
  • paseo-shared-browser/shared/agent-access.ts
  • paseo-shared-browser/tests/agent-filter.test.ts
Latest Contributors(0)
UserCommitDate


Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ade3973b-7ad1-4472-8fca-c2d5f4517c5f
Commits

Reviewing files that changed from the base of the PR and between 069d8f8 and f4e8dd9.

Files selected for processing: 4

  • paseo-shared-browser/README.md
  • paseo-shared-browser/shared/agent-access.ts
  • paseo-shared-browser/tests/agent-filter.test.ts
  • paseo-shared-browser/tests/contracts.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant