Skip to content

feat(paseo-omp): draw provider marks and lay OMP account cards out in fixed-width rows - #635

Open
taemire wants to merge 13 commits into
omercnet:mainfrom
taemire:feat/paseo-omp-provider-marks
Open

taemire wants to merge 13 commits into
omercnet:mainfrom
taemire:feat/paseo-omp-provider-marks

Conversation

@taemire

@taemire taemire commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Last part of the split of #631: provider marks and the Accounts card layout. Stacked on #634; it waits for your licence decision on the marks.

Changes

  • Provider marks for Claude, OpenAI, Copilot, Antigravity and Grok ship as currentColor SVG in shared/provider-icons/, the same paths Paseo's own provider list draws, and appear in the quota pill, the popover headers and the Accounts tab. Other providers keep their Lucide icon.
  • Accounts cards are a fixed 440px wide and wrap, as many to a row as the page fits; a page narrower than one card shrinks the card. Nothing is measured, so resizing does not flip the column count.

Licence

The marks are the vendors' logos. This repository is MIT and Paseo's icon files carry no licence header, so please decide whether the repository should carry them. Dropping shared/provider-icons/ and client/provider-brand.ts leaves the Lucide icons and the card layout intact.

Verification

  • npm run check, npm run typecheck: passed.
  • npm test: 100 files passed, 1 skipped; 1515 tests passed, 8 skipped.
  • Accounts cards measured at 800, 1100, 1400 and 1900px and back, with the same rows each time.

Isolated daemon with fictional logins on example.invalid:

Before After
Pill Before: Lucide icon After: Claude mark
Popover Before: Lucide icons After: provider marks

Accounts tab at 1900px, before:

Before: full-width login cards stacked one per row

After, fixed-width cards wrapping three to a row with provider marks:

After: fixed-width cards with provider marks

JangMinSeok added 13 commits November 16, 2026 22:43
- Read each account's plan and organization from OMP's cached usage reports and show them as badges.
- Show an Anthropic organization named after the account's email as Personal.
- Show reset countdowns a day or more away as days and hours.
- Move plan and organization badges into the account heading row and its accessibility label.
- Accounts cards show the plan and organization badges the quota popover shows, from OMP's cached usage report, and drop OMP's parenthesized organization from the label once a badge shows it.
- One tag rule in shared/account-tags.ts serves both views; `tags` defaults to an empty list.
…ve session

- Paseo shows an OMP Plugin agent's model as an opaque id, so the quota pill and popover could not tell its provider and summarized every provider.
- New RPC paseo-omp.session-model-provider asks the agent's live session, which maps the id back to OMP's model; a closed or unknown agent answers null and keeps the old summary.
- The pill asks only for agents that are not closed and reuses the answer until the agent's model or status changes; the open popover asks again on the same changes.
- The quota popover lists the session's OMP logins (get_logout_accounts, or the stored session pin for a bundled omp agent), marks the one in use IN USE, a provider's only stored credential ONLY LOGIN, and offers Switch, which sends `/session pin OAuth credential #<id>`.
- Logins link to recorded usage server-side by OMP's identity rule within the agent's own store.
- The composer pill shows the in-use account's usage; dividers separate accounts and redundant notices are gone.
…ion account review gaps

- Switch is disabled while the agent is running or initializing: Paseo interrupts a running turn on send, and OMP does not pin while it streams. Its accessible name uses the login label and its hit area grows by 8px.
- Two logins sharing a usage account keep IN USE on the one in use.
- The pill falls back to the provider peak when the account in use has no usage value, and its tooltip then says all accounts.
- Tests cover Paseo's agent lookup through the registered RPC; a comment names the two parts of OMP's identity rules the matcher leaves out.
- README lists what reaches the client and the limit of the Copilot single-login link.
…an unlinked login in use

- Drop the rule that linked a provider's single identity-less login to its single usage account: one login and one usage key do not prove ownership, so a replaced Copilot login no longer inherits its predecessor's usage.
- A login OMP names in use, or the provider's only one, that no usage row matches is named at the top of its provider with IN USE or ONLY LOGIN and no limits, for every provider alike.
- Switch's hit slop brings its touch target to 44px; test fixtures drop token- and host-shaped values.
…s login in use

- OMP's get_logout_accounts decides `active` by identity, so a pinned Copilot login reads as not in use in a live OMP Plugin session; the popover keeps OMP's answer.
- Ship the Claude, OpenAI, Copilot, Antigravity and Grok marks Paseo uses as currentColor SVG.
- Keep Lucide icons for other providers; severity still tints the mark.
…th provider marks

- Provider headings on the Accounts tab show the provider's brand mark.
- Account cards share a row by the width available: one, two or three per row.
- Cards wrap into columns away from their provider heading, so each shows the provider mark before its name.
- Measuring the grid's own width fed back into the card widths, so resizing flipped between two and three columns.
- Cards are now 440px wide and wrap as many to a row as the page fits; a narrower page shrinks the card.
@taemire
taemire requested a review from omercnet as a code owner November 16, 2026 14:48
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 64fb9631-60b5-4aac-b236-74346798af71
Commits

Reviewing files that changed from the base of the PR and between 5e26f04 and 6567e55.

Files ignored due to path filters: 5

  • paseo-omp/shared/provider-icons/antigravity.svg is excluded by !**/*.svg
  • paseo-omp/shared/provider-icons/claude.svg is excluded by !**/*.svg
  • paseo-omp/shared/provider-icons/codex.svg is excluded by !**/*.svg
  • paseo-omp/shared/provider-icons/copilot.svg is excluded by !**/*.svg
  • paseo-omp/shared/provider-icons/grok.svg is excluded by !**/*.svg
Files selected for processing: 27

  • paseo-omp/README.md
  • paseo-omp/client/omp-accounts-section.tsx
  • paseo-omp/client/provider-brand.ts
  • paseo-omp/client/provider-icon.tsx
  • paseo-omp/client/quota-popover.tsx
  • paseo-omp/client/quota-state.ts
  • paseo-omp/index.client.tsx
  • paseo-omp/index.server.ts
  • paseo-omp/server/omp-accounts.ts
  • paseo-omp/server/provider/omp-rpc-protocol.ts
  • paseo-omp/server/provider/omp-rpc.ts
  • paseo-omp/server/provider/session.ts
  • paseo-omp/server/quota.ts
  • paseo-omp/server/subagents.ts
  • paseo-omp/shared/account-tags.ts
  • paseo-omp/shared/omp-accounts.ts
  • paseo-omp/shared/quota.ts
  • paseo-omp/tests/helpers/provider-harness.ts
  • paseo-omp/tests/omp-accounts-state.test.ts
  • paseo-omp/tests/omp-accounts.test.ts
  • paseo-omp/tests/omp-state.test.ts
  • paseo-omp/tests/omp-store-client.test.ts
  • paseo-omp/tests/profile-pills.test.ts
  • paseo-omp/tests/provider-subagent-control.test.ts
  • paseo-omp/tests/quota-popover-session-provider.test.tsx
  • paseo-omp/tests/quota-popover.test.tsx
  • paseo-omp/tests/quota-state.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@baz-reviewer

baz-reviewer Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Add vendor brand icons and responsive fixed-width account-card layout across OMP surfaces, while making quota summaries session-aware and enabling active-login identification, account switching, badges, and opaque-model provider resolution. Extend server RPCs, runtime protocol support, credential-to-usage matching, profile-store handling, documentation, and comprehensive tests to support these flows safely.

Topics

TopicDetails
Credential resolution Add server-side RPCs and store-aware resolution for live session providers and OAuth logins, securely link credentials to hashed usage-account keys using OMP identity rules, support profile-specific stores and sticky-session fallback, and avoid exposing raw account identifiers.
Modified files (4)
  • paseo-omp/index.server.ts
  • paseo-omp/server/omp-accounts.ts
  • paseo-omp/server/quota.ts
  • paseo-omp/server/subagents.ts
Latest Contributors(0)
UserCommitDate
Branding and layout Render currentColor vendor marks for supported providers and arrange account cards into fixed 440px wrapping columns that shrink on narrow pages, while preserving fallback Lucide icons.
Modified files (8)
  • paseo-omp/client/omp-accounts-section.tsx
  • paseo-omp/client/provider-brand.ts
  • paseo-omp/client/provider-icon.tsx
  • paseo-omp/shared/provider-icons/antigravity.svg
  • paseo-omp/shared/provider-icons/claude.svg
  • paseo-omp/shared/provider-icons/codex.svg
  • paseo-omp/shared/provider-icons/copilot.svg
  • paseo-omp/shared/provider-icons/grok.svg
Latest Contributors(0)
UserCommitDate
Runtime integration Extend the OMP runtime protocol and provider session lifecycle to report the model’s underlying provider and active logout accounts, including validation, unsupported-command handling, closed-session behavior, and runtime error boundaries.
Modified files (4)
  • paseo-omp/server/provider/omp-rpc-protocol.ts
  • paseo-omp/server/provider/omp-rpc.ts
  • paseo-omp/server/provider/session.ts
  • paseo-omp/tests/helpers/provider-harness.ts
Latest Contributors(0)
UserCommitDate
Regression coverage Update state, account, quota, provider-pill, popover, runtime-control, store, and server tests to cover branding, responsive rendering, account badges, active-login ordering, switching safeguards, opaque provider lookup, profile isolation, identity matching, cache failures, and protocol fallbacks.
Modified files (9)
  • paseo-omp/tests/omp-accounts-state.test.ts
  • paseo-omp/tests/omp-accounts.test.ts
  • paseo-omp/tests/omp-state.test.ts
  • paseo-omp/tests/omp-store-client.test.ts
  • paseo-omp/tests/profile-pills.test.ts
  • paseo-omp/tests/provider-subagent-control.test.ts
  • paseo-omp/tests/quota-popover-session-provider.test.tsx
  • paseo-omp/tests/quota-popover.test.tsx
  • paseo-omp/tests/quota-state.test.ts
Latest Contributors(0)
UserCommitDate
Session-aware quotas Enrich quota and account models with plan, organization, provider, identity, and session-account metadata; display badges, active-login markers, account dividers, reset durations, account-scoped summaries, provider resolution, and safe account switching in the pill and popover.
Modified files (6)
  • paseo-omp/client/quota-popover.tsx
  • paseo-omp/client/quota-state.ts
  • paseo-omp/index.client.tsx
  • paseo-omp/shared/account-tags.ts
  • paseo-omp/shared/omp-accounts.ts
  • paseo-omp/shared/quota.ts
Latest Contributors(0)
UserCommitDate
Behavior documentation Document provider marks, account badges, session/account matching rules, store isolation, switching behavior, provider resolution, quota semantics, and reset formatting so the expanded user-facing flow and its privacy guarantees are explicit.
Modified files (1)
  • paseo-omp/README.md
Latest Contributors(0)
UserCommitDate


Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

Comment on lines +358 to +362
{sessionAccounts.error ? (
// The host wraps handler errors in transport details; only a short notice belongs here.
<Text style={styles.muted}>Could not read which account this session uses.</Text>
) : null}
{switchError ? <Text style={styles.error}>{switchError}</Text> : null}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account errors stay silent to assistive technology

Screen readers do not announce session-account or switch errors because both are rendered as ordinary Text; render them with accessibilityRole="alert" or an equivalent live-region mechanism.

Severity

Want Baz to fix this for you? Activate Fixer

Prompt for AI Agents
Before applying, verify this suggestion against the current code. In
paseo-omp/client/quota-popover.tsx around lines 358-362, update the `QuotaPopover` error
rendering for `sessionAccounts.error` and `switchError` so failures are announced to
assistive technology. Add `accessibilityRole="alert"` to both error messages, or use the
repository’s equivalent live-region mechanism if that is the established convention.

Comment thread paseo-omp/server/quota.ts
Comment on lines +391 to +393
return await withOmpStore(storeForProvider(agent.provider), async () => {
const databasePath = defaultDatabasePath();
const logins = await sessionLogins(input, registry, agent.sessionId, databasePath);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Session logins read from daemon default store

Agents with no live session can show the wrong logins—or none—because resolveListOmpSessionAccounts reads the default agent.db and store even when providerOptions.command launches OMP with a different agent directory; derive the database from the agent’s effective launch environment, or don’t attribute default-store data to the non-live agent.

Severity web_search

Want Baz to fix this for you? Activate Fixer

Prompt for AI Agents
Before applying, verify this suggestion against the current code. In
`paseo-omp/server/quota.ts` around lines 391-393, fix `resolveListOmpSessionAccounts` so
it does not always use `defaultDatabasePath()` for non-live agents. Derive the database
path from the agent’s effective launch environment/provider options, including
env-wrapper commands such as `PI_CODING_AGENT_DIR=/custom/agent`; if the path cannot be
determined reliably, return no accounts instead of reading unrelated default-store data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant