Repository navigation
Conversation
…ve session - Paseo shows an OMP Plugin agent's model as an opaque id, so the quota pill and popover could not tell its provider and summarized every provider. - New RPC paseo-omp.session-model-provider asks the agent's live session, which maps the id back to OMP's model; a closed or unknown agent answers null and keeps the old summary. - The pill asks only for agents that are not closed and reuses the answer until the agent's model or status changes; the open popover asks again on the same changes.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
| Topic | Details | |||
|---|---|---|---|---|
| Flow Verification | Verify live-session provider lookup, null responses after runtime exit, provider-specific pill rendering, and cache invalidation when model or status changes.Modified files (3)
Latest Contributors(0)
| |||
| Provider Quota Attribution | Resolve an OMP Plugin agent’s opaque model through its live OmpProviderSession, expose it via paseo-omp.session-model-provider, and use the result to show provider-specific quota summaries and current-provider markers while preserving all-provider behavior for closed sessions.Modified files (8)
Latest Contributors(0)
|
| const provider = (agentId: string) => | ||
| resolveGetOmpSessionModelProvider({ agentId }, registry).provider; | ||
|
|
There was a problem hiding this comment.
RPC provider lookup route escapes coverage
The regression test bypasses the registered RPC route, so it still passes if paseo-omp.session-model-provider is missing or wired to the wrong resolver; invoke it through the server and assert the provider result and unknown-operation error when the route is removed.
Want Baz to fix this for you? Activate Fixer
Prompt for AI Agents
Before applying, verify this suggestion against the current code. In
paseo-omp/tests/provider-subagent-control.test.ts around lines 458-460, update the `get
OMP provider` regression test so it exercises `paseo-omp.session-model-provider` through
the registered server RPC route instead of calling `resolveGetOmpSessionModelProvider`
directly. Assert the transported response contains the expected provider, and add a
focused check that removing or bypassing the route causes the operation to be reported
as unknown.
omercnet
left a comment
There was a problem hiding this comment.
thanks @taemire, this one is good to merge once the thread is resolved. i checked the root cause: the model id is a hash from ompModelId, so the provider could never be parsed from it, and it has been like that since the first plugin commit. the rpc returns only a provider id, only for a live session, and does no OMP call, so it cannot disturb a turn. an old server without the rpc falls back to today's summary.
one thing for the merge: the open baz thread at tests/provider-subagent-control.test.ts:460 asks for the new rpc name in the route list in tests/server-bundle.test.ts. please add it and resolve the thread, main needs all threads resolved.
small follow ups, none blocking: cache a failed lookup under the same key (provider null) so an old or reloading server is not asked once per OMP Plugin agent on every reconcile (index.client.tsx:393-402), skip closed agents in the popover query as the pill path already does, add a rejected-rpc test and a two-agent server test. i can push the route-list line if you prefer, just say so.
Found while running the live check #631 asked for on an
omp-pluginagent.Problem
Paseo shows an OMP Plugin agent's model only as an opaque
omp:model:<hash>id.quotaProviderFromSessionreads the provider from aprovider/modelstring, so for every OMP Plugin agent it returned null: the composer pill summarized every provider (Quotas · 100%) and the popover never marked a CURRENT PROVIDER. Bundledompagents were not affected because their model string carries the provider.Changes
paseo-omp.session-model-provider({ agentId }to{ provider }). The agent's live session maps its opaque model id back to OMP's model through the catalog it already holds (modelProvider()on the session controls). A closed, history-only or unknown agent answersnull, which keeps today's all-provider summary.closed, and reuses the answer until the agent's model or status changes, so a directory update does not fan out one RPC per agent.Verification
npm run check,npm run typecheck: passed.npm test: 100 files passed, 1 skipped; 1490 tests passed, 8 skipped.omp-pluginagent on an Anthropic model, seeded with fictional logins onexample.invalid:The pill truncates to
Anthropic · 10…in the current label format; the session account PR shortens the pill to the percentage.