Attempt to Update Bitflags#128
Open
reece394 wants to merge 1 commit intoomerbenamram:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps bitflags up to the latest release 2.7. In order to do this I had to add derive lines to maintain compatibility with the older version. I also had to use fmt::Display to change the output back to the way it was before the update as the latest version of bitflags outputs like this FileAttributeFlags(FILE_ATTRIBUTE_READONLY) rather than FILE_ATTRIBUTE_READONLY.
One potential issue I noticed is when I used mft_dump json with mft_dump --output-format json --output test1.json mft.bin
and compared the outputs of the older version is that it outputs IndexRootFlags with both SMALL_INDEX and LARGE_INDEX rather than just LARGE_INDEX for the older version. This might be due to the way the bits are handled now but the rest of the outputs seem to match fine and pass the tests.
The default behaviour is to not output any info for 0x00 flags anymore in bitflags hence the if statement in IndexRootFlags FYI