build(deps): bump Go to 1.26.5 (fix GO-2026-5856) + x/term, docker, setup-go - #112
Merged
Conversation
…etup-go Root fix: cli/go.mod `go 1.26.4` -> `1.26.5`. All workflows install Go via `go-version-file: cli/go.mod`, so CI was building with the vulnerable 1.26.4 stdlib and govulncheck failed on GO-2026-5856 (crypto/tls, fixed in 1.26.5) for every PR. Consolidates the open Dependabot PRs: - golang.org/x/term 0.44.0 -> 0.45.0 (#110) - Dockerfile golang 1.26.4-alpine -> 1.26.5-alpine (#109) - actions/setup-go v6 -> v7 across all workflows (#111) Local: go mod tidy, go vet, go build, go test, and govulncheck v1.1.4 all pass ("No vulnerabilities found"). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe pull request updates the Go toolchain from 1.26.4 to 1.26.5, refreshes two Go module dependencies, and changes all GitHub Actions Go setup steps from ChangesGo toolchain updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Every workflow installs Go via
go-version-file: cli/go.mod, which pinnedgo 1.26.4. So CI (incl.govulncheck) built with the 1.26.4 stdlib and failed GO-2026-5856 (crypto/tls, fixed in 1.26.5) on every PR — blocking #109/#110/#111.Changes (consolidates all 3 open Dependabot PRs + the root fix)
cli/go.modgo 1.26.4→1.26.5← unblocks govulncheckgolang.org/x/term0.44.0 → 0.45.0 (build(deps): bump golang.org/x/term from 0.44.0 to 0.45.0 in /cli in the go-minor-patch group #110)Dockerfilegolang 1.26.4-alpine → 1.26.5-alpine (build(deps): bump golang from 1.26.4-alpine to 1.26.5-alpine #109)actions/setup-gov6 → v7 across all workflows (build(deps): bump actions/setup-go from 6 to 7 in the actions group #111)Verification (local, Go 1.26.5)
go mod tidy,go vet,go build,go test ./...all pass;govulncheck v1.1.4→ No vulnerabilities found.🤖 Generated with Claude Code
Summary by CodeRabbit