Stop previewing received Taildrop images - #9891
Open
rcssdy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Taildrop receiver passes received image files directly to the notification service with
--image.This causes Quickshell to decode received image contents automatically, before the recipient interacts with the notification. Some Qt image decoders can allocate memory proportional to the encoded file size even when a small
sourceSizeis requested, allowing a sufficiently large received image to exhaust Quickshell’s available memory.Fix
Use the existing generic file glyph for every received Taildrop file instead of attaching image files as notification previews.
The existing behavior is otherwise preserved:
Tests
bash test/shell.d/tailscale-receive-test.shbash -n bin/omarchy-tailscale-receive test/shell.d/tailscale-receive-test.shgit diff --checkThe regression test now verifies that received images are not passed to the notification service through
--image.