feat(reader): fold long code blocks - #31
Open
oldwinter wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
❌ Deploy Preview for aquamarine-salamander-b041fe failed. Why did it fail? →
|
Owner
Author
|
Blocking DESIGN violation at exact head Unblock action: remove the non-whitelisted transition and attach executable DOM/browser coverage for fold eligibility, focus and lifecycle before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long syntax-highlighted code blocks now start at a compact reading height and expand in place from a localized chevron beside the existing copy control, while short blocks, Mermaid diagrams, no-JavaScript output, and print output stay untouched. It is worth merging because dense technical notes become easier to scan without sacrificing source access, keyboard accessibility, or the existing copy and horizontal-scroll workflows.
Validation
npx tsx --test quartz/components/scripts/codeFolding.test.ts quartz/plugins/emitters/componentResources.test.ts(15/15 passed)npx tsc --noEmitgit diff --checknpx quartz build(314 Markdown inputs, 1912 outputs)npm test: 241/242 passed; the sole failure is the existing undeclaredjsdomimport in untouchedlocal-plugins/theme-switcher/test/themeSwitcherScript.test.tsImpact
Rollback
Revert commit
69f9b49be3fff608f282b4caf5ae48ee57dcc0eb. Static HTML always retains the full code content, so rollback has no content migration or data cleanup.Hosted status
Netlify deploy preview
6a93410fa2fce600089f403efailed all four contexts with an unavailable public summary, no messages, and zero GitHub annotations. Merged baseline PR #29 has the same four-context failure pattern, while this exact SHA passes the local production build and browser QA above. No deployment, configuration, authentication, or infrastructure changes were made.