feat(reader): add reading comfort controls - #23
Open
oldwinter wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
❌ Deploy Preview for aquamarine-salamander-b041fe failed. Why did it fail? →
|
Owner
Author
|
Blocking review at exact head
Unblock action: rebase onto current v5, fix computed CSS for headings and inline code, decouple sibling disclosure state, and add real computed-style/browser regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built a compact
Aareading-comfort control for article pages, with 90%, 100%, 110%, and 120% body-text sizes that persist locally and survive Quartz SPA navigation. It is worth merging because it makes long-form reading immediately more comfortable without changing the site's layout, metadata, code blocks, dependencies, or publishing configuration.Validation
npx tsx --test quartz/components/scripts/readingComfort.test.ts quartz/plugins/emitters/componentResources.test.ts quartz/components/renderPage.test.ts- 24/24 passednpx tsc --noEmit- passednpx prettier --check ...- passednpx quartz build- passed; 314 Markdown inputs emitted 1,911 filesnpm testrun: 226/227 passed; the remaining existing theme-switcher test cannot resolve the undeclaredjsdompackageImpact
reading-comfortlocal-storage preferenceRollback
Revert commit
b1cccf1879b729914deac7e3fed77fd3deb27f09. The only persisted state is the harmlessreading-comfortlocal-storage key.Known baseline warnings
The production build still reports the repository's existing generated-plugin
evalwarning, one invalid content date, and a Google Fonts HTTP 400 warning for LXGW WenKai.