Skip to content

feat(reader): copy notes as Markdown links - #22

Open
oldwinter wants to merge 1 commit into
v5from
happy-hour/markdown-note-link
Open

feat(reader): copy notes as Markdown links#22
oldwinter wants to merge 1 commit into
v5from
happy-hour/markdown-note-link

Conversation

@oldwinter

@oldwinter oldwinter commented Aug 25, 2026

Copy link
Copy Markdown
Owner

This builds a second, localized reader action that copies the current note as a portable Markdown link ([title](<URL>)) beside the existing share control. It is worth merging because it turns the public garden into a one-click source for references that can be pasted directly into Obsidian, READMEs, and other notes, while keeping whole-note links clean and predictable.

Validation

  • Exact commit: e7dc5683d878fdc9a4a9360ddfa707a9991ce167
  • Focused reader/render tests: 25/25 passed
  • TypeScript: npx tsc --noEmit passed
  • Changed TypeScript files: Prettier check passed
  • Diff hygiene: git diff HEAD --check passed with a clean worktree
  • Production build: 314 Markdown inputs, 1,910 emitted files
  • Real Chrome QA passed at 1280px light/dark and 320px dark with reduced motion:
    • pointer and keyboard copy paths
    • exact Markdown clipboard payload
    • square-bracket, backslash, whitespace, and parenthesized-URL handling
    • heading-fragment removal
    • success and clipboard-failure feedback
    • focus-visible and post-copy focus restoration
    • SPA navigation/render cleanup with one control instance
    • no horizontal overflow or browser page errors
  • Full suite: 225/226 passed. The only failure is the existing local-plugins/theme-switcher/test/themeSwitcherScript.test.ts import of undeclared jsdom; this branch does not change that test or any dependency manifest.

Impact

  • Eight focused design, reader-script, render-data, locale, and test files
  • No dependency, lockfile, content, configuration, CI, infrastructure, deployment, permission, secret, analytics, storage, or new network behavior
  • Markdown titles normalize whitespace and escape backslashes and square brackets; destinations use angle brackets so valid URLs containing parentheses remain portable
  • English, Simplified Chinese, and Traditional Chinese labels and outcomes are included, with the existing English fallback for other locales

Rollback

Revert e7dc5683d878fdc9a4a9360ddfa707a9991ce167. There is no stored data, migration, or external state to clean up.

Hosted checks

Netlify deploy 6a8de1a004cccc00082157a5 failed all four preview contexts for the exact commit. The three check runs contain zero annotations and only report Deploy failed; Netlify's public deploy response reports summary.status: unavailable with no messages. The exact commit passes the local production build and real-browser QA above, and this branch does not change deployment or repository configuration, so this remains an opaque external preview-service blocker rather than a locally reproducible regression.

@oldwinter oldwinter added the enhancement New feature or request label Aug 25, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for aquamarine-salamander-b041fe failed. Why did it fail? →

Name Link
🔨 Latest commit e7dc568
🔍 Latest deploy log https://app.netlify.com/projects/aquamarine-salamander-b041fe/deploys/6a8de1a004cccc00082157a5

@oldwinter

Copy link
Copy Markdown
Owner Author

Two-axis code review is clean at exact head e7dc5683d878fdc9a4a9360ddfa707a9991ce167, but the branch conflicts with current v5 and saved QA was not independently rerun on a conflict-resolved head. Current tests regex-check SPA lifecycle/focus code rather than executing navigation, fragment removal, focus restoration and browser clipboard behavior.

Unblock action: resolve the branch against current v5 and attach exact-head rendered browser/keyboard QA plus executable SPA/focus regression evidence before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant