feat(reader): add a session reading trail - #21
Open
oldwinter wants to merge 1 commit into
Open
Conversation
❌ Deploy Preview for aquamarine-salamander-b041fe failed. Why did it fail? →
|
Owner
Author
|
Blocking review at exact head
Unblock action: rebase onto current v5, introduce shared disclosure/storage behavior, and add executable DOM tests for keyboard mutual exclusion plus write-only storage failure. Focused tests pass but source-regex lifecycle tests do not cover these paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built a localized Reading Trail that remembers the notes visited earlier in the current tab and makes them one click away from the existing reader action row. I think it is worth merging because wandering through backlinks and Random Wander is one of the garden's best interactions, and this gives readers a quiet, reversible path through that exploration without accounts, long-term tracking, or another network request.
What changed
sessionStorage, newest firstnav, in-placerender, full reload, cleanup, andReadLaterpanel mutual exclusionValidation
tsc --noEmit: passedgit diff --check: passedReadLaterexclusion, 1280px desktop, 320px mobile, dark/light, reduced motion, long-list scrolling, and extreme text clamping all passed with no page errorsjsdom, in unchanged code6a8c8e6facc50100081c10cdended inerrorwith no error message and GitHub exposed zero annotations, so no deployment configuration or credentials were changedImpact
Rollback
Revert commit
c1cdc31a08cb5350cf7570a2a12e3062cba9cb3e. The feature is isolated; removing its script/style registration, locale fields, and storage module restores the prior reader action row. Existing browser session data is inert without the script.