Skip to content

feat: infer reusable discriminant match selections - #10

Merged
okyrychenko-dev merged 2 commits into
mainfrom
feat/deepen-discriminant-matching
Oct 1, 2026
Merged

okyrychenko-dev merged 2 commits into
mainfrom
feat/deepen-discriminant-matching

Conversation

@okyrychenko-dev

Copy link
Copy Markdown
Owner

Summary

Adds matchPredicateFor<Q>() so callers bind the source union once and infer keys and selections without repeating selected types. Existing calls and lifecycle behavior remain compatible.

Changes

  • Add bound matching types, shared runtime logic, and module/package-root exports.
  • Extend hook tests and packed ESM/CommonJS consumer checks.
  • Update README examples and changelog.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T09:38:00.361408Z 94a14ec New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 011bbb6fab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/useEffectWhenMatch/useEffectWhenMatch.types.ts Outdated
@okyrychenko-dev
okyrychenko-dev merged commit eaac330 into main Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant