Add api_test.mustache template for auto-generated test classes#1674
Open
agrja-rastogi-okta wants to merge 5 commits intomasterfrom
Open
Add api_test.mustache template for auto-generated test classes#1674agrja-rastogi-okta wants to merge 5 commits intomasterfrom
agrja-rastogi-okta wants to merge 5 commits intomasterfrom
Conversation
This template generates comprehensive unit tests for all API operations. Each test: - Loads prerequisite data created by Terraform - Extracts method parameters from the prerequisite data - Executes the actual API method - Validates HTTP response codes (200, 201, 202, 204) The template includes: - Smart parameter extraction that handles field name variations - Support for file uploads via file_path parameter - Automatic model deserialization with fallback to alternative class names - Comprehensive error handling and validation - Javadoc comments explaining test behavior This enables automated testing of all Okta SDK operations against live APIs while maintaining code consistency and reducing manual test maintenance.
The toSnakeCase method was not being called anywhere in the template. The camelCase to snake_case conversion is already handled by TerraformHelper.getPrerequisiteDataForTest() on the backend.
prachi-okta
reviewed
Feb 20, 2026
|
|
||
| // Extract parameters from prerequisite data | ||
| Map<String, Object> payload = (Map<String, Object>) prerequisiteData.getOrDefault("payload", new HashMap<>()); | ||
| Map<String, Object> prerequisiteObject = (Map<String, Object>) prerequisiteData.getOrDefault("prerequisite_object", new HashMap<>()); |
Contributor
There was a problem hiding this comment.
prerequisiteObject is extracted but never referenced anywhere in the test body.
Contributor
Author
There was a problem hiding this comment.
removed all unused variables.
prachi-okta
reviewed
Feb 20, 2026
| byte[] fileContent = null; | ||
| if (payload.containsKey("file_path")) { | ||
| String filePath = payload.get("file_path").toString(); | ||
| fileContent = Files.readAllBytes(Paths.get(filePath)); |
Contributor
There was a problem hiding this comment.
fileContent is declared, conditionally populated by reading from disk, but never passed to any API method call.
Contributor
Author
There was a problem hiding this comment.
removed all unused variables, this will be handled in a helper now.
prachi-okta
reviewed
Feb 20, 2026
| import {{import}}; | ||
| {{/imports}} | ||
|
|
||
| import java.io.File; |
Contributor
There was a problem hiding this comment.
java.io.File is imported but never used anywhere in the template. This will produce an unused import warning in every generated class.
Contributor
Author
There was a problem hiding this comment.
removed all unused imports.
agrja-rastogi-okta
added a commit
that referenced
this pull request
Feb 25, 2026
… support - Remove unused java.nio.file imports (Files, Paths) - Remove unused prerequisiteObject variable extraction - Remove unused fileContent variable and related logic - Remove unused payload variable declaration - Add file parameter handling in TerraformHelper.extractParameter() to support File type parameters like uploadApplicationLogo() This addresses all three review comments from PR #1674 while maintaining file upload capability for APIs that need it.
- Remove unused java.io.File import - Remove unused java.nio.file imports (Files, Paths) - Remove unused prerequisiteObject variable extraction - Remove unused fileContent variable and related logic - Remove unused payload variable declaration This addresses all three review comments from PR #1674.
prachi-okta
reviewed
Feb 25, 2026
| /** | ||
| * Convert camelCase to snake_case | ||
| */ | ||
| private String toSnakeCase(String camelCase) { |
Contributor
There was a problem hiding this comment.
this is also not being called anywhere but it is defined.
The toSnakeCase method was defined but never called anywhere in the template or generated test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This template generates comprehensive unit tests for all API operations. Each test:
The template includes:
This enables automated testing of all Okta SDK operations against live APIs while maintaining code consistency and reducing manual test maintenance.