Skip to content

fix(transcode): only pick a GPU encoder when its device is present #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohugonnot merged 1 commit into from
May 29, 2026
Merged

fix(transcode): only pick a GPU encoder when its device is present #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,15 +743,20 @@ function detect_hw_encoder(): string {
}
}

// NVENC (Nvidia GPU)
// NVENC (Nvidia GPU) — h264_nvenc peut être compilé dans ffmpeg SANS qu'aucun
// GPU ne soit présent. Exiger un device NVIDIA réel, sinon on choisirait nvenc
// sur une machine sans carte → échec runtime "Cannot load libcuda.so.1" et
// lecture cassée. (VAAPI fait déjà cette vérif de device plus haut.)
$encoders = shell_exec('ffmpeg -encoders 2>/dev/null') ?? '';
if (str_contains($encoders, 'h264_nvenc')) {
$hasNvidiaDevice = file_exists('/dev/nvidia0') || file_exists('/dev/nvidiactl');
if ($hasNvidiaDevice && str_contains($encoders, 'h264_nvenc')) {
$cached = 'nvenc';
return $cached;
}

// V4L2 M2M (Raspberry Pi 4)
if (file_exists('/dev/video10') || str_contains($encoders, 'h264_v4l2m2m')) {
// V4L2 M2M (Raspberry Pi 4) — pareil : exiger le device ET l'encodeur, pas l'un
// ou l'autre (un ffmpeg complet liste h264_v4l2m2m même hors Pi).
if (file_exists('/dev/video10') && str_contains($encoders, 'h264_v4l2m2m')) {
$cached = 'v4l2m2m';
return $cached;
}
Expand Down
21 changes: 21 additions & 0 deletions tests/HwAccelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@ public function testDetectHwEncoderReturnsNoneWhenNoGpu(): void
$this->assertNotEmpty($result);
}

/**
* En mode auto, un backend GPU ne doit être choisi QUE si son device existe —
* sinon ffmpeg liste l'encodeur (compilé) mais l'encodage plante au runtime
* (ex. nvenc sans GPU : "Cannot load libcuda.so.1"). Régression réelle observée
* en prod sur un serveur sans carte dont le ffmpeg embarquait nvenc.
*/
public function testGpuBackendChosenOnlyWhenDevicePresent(): void
{
$result = detect_hw_encoder();
if ($result === 'nvenc') {
$this->assertTrue(
file_exists('/dev/nvidia0') || file_exists('/dev/nvidiactl'),
'nvenc ne doit être choisi que si un device NVIDIA est présent'
);
} elseif ($result === 'v4l2m2m') {
$this->assertTrue(file_exists('/dev/video10'), 'v4l2m2m exige /dev/video10');
} else {
$this->assertContains($result, ['none', 'vaapi']);
}
}

// ── buildFfmpegCodecArgs with hardware encoders ──────────────────────

public function testBuildFfmpegCodecArgsSoftware(): void
Expand Down
Loading