Repository navigation
Pause public intake until storage safeguards are ready - #5
Conversation
ECC Tools / Security EvidenceCommit: Security evidence gate passed (success) No security-sensitive scanner-evidence gap detected. Mode: enforce Scanned 2 changed file(s). No missing scanner-evidence signal was detected. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Risk TaxonomyCommit: PR taxonomy clear (success) Scanned 2 changed file(s). No taxonomy bucket signals were detected. Scanned 2 changed file(s). No PR taxonomy bucket signals were detected. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Reference Set ReadinessCommit: Reference set readiness gaps detected (neutral) Reference evidence present for 0/7 areas (0%) across 2 changed file(s). This check is based on files changed in this PR. Repository-level readiness is still reported by
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Hosted Promotion ReadinessCommit: Hosted promotion readiness passed (success) No hosted promotion evidence gaps detected across 2 changed file(s); 0 corpus scenarios had matching evidence. This check compares PR file changes against the evaluator/RAG promotion corpus in No evaluator corpus scenarios matched this PR. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa8b08e3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (form.dataset.intakeEnabled !== 'true') { | ||
| submit.disabled = true; | ||
| status.textContent = 'Online requests are temporarily paused. Please email hello@ohgeec.com. Do not include passwords.'; | ||
| return; |
There was a problem hiding this comment.
When visitors follow the /tech-support/onsite-montana/ link to /book.html?mode=onsite, this return skips all subsequent mode handling, so the booking page incorrectly retains its remote-support headline, pricing, categories, and default service mode. Move the intake-enabled guard below the URL-driven page initialization while still returning before the submit handler is registered.
Useful? React with 👍 / 👎.
| <p class="sub">Tell me what is happening and when works for you. I will follow up using your preferred contact method.</p> | ||
|
|
||
| <form id="service-request" data-intake-form data-intake-endpoint="https://parrot.tail60dba7.ts.net:8443/v1/intake"> | ||
| <form id="service-request" data-intake-form data-intake-enabled="false" data-intake-endpoint="https://parrot.tail60dba7.ts.net:8443/v1/intake"> |
There was a problem hiding this comment.
After the storage safeguards are installed, the documented activation procedure in DEPLOY.md:20 only sets PUBLIC_INTAKE_ENABLED=true and recreates the intake container. This hard-coded client flag belongs to the separately deployed static site and has no connection to that environment variable, so following the runbook leaves the submit button permanently disabled even though the receiver is enabled; coordinate flipping and redeploying this attribute with server activation, or avoid the independent client-side gate.
Useful? React with 👍 / 👎.
1 participant
The public receiver rejects requests while
PUBLIC_INTAKE_ENABLED=false, but the booking page still transmitted entered values to it. Disable the form submit client-side while storage protections are pending, show an email fallback, and make no network request with visitor data.