Repository navigation
fix(v5.0.1): restore complete updater files - #380
Conversation
ECC Tools / Security EvidenceCommit: Security evidence gate passed (success) No security-sensitive scanner-evidence gap detected. Mode: enforce Scanned 3 changed file(s). No missing scanner-evidence signal was detected. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Risk TaxonomyCommit: PR taxonomy review recommended (neutral) Detected 1 PR taxonomy bucket(s): CI/CD Recommendation. Scanned 3 changed file(s). Roadmap taxonomy buckets: CI/CD RecommendationCI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work. Signals:
Paths:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Reference Set ReadinessCommit: Reference set readiness gaps detected (neutral) Reference evidence present for 0/7 areas (0%) across 3 changed file(s). This check is based on files changed in this PR. Repository-level readiness is still reported by
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Hosted Promotion ReadinessCommit: Hosted promotion readiness passed (success) No hosted promotion evidence gaps detected across 3 changed file(s); 0 corpus scenarios had matching evidence. This check compares PR file changes against the evaluator/RAG promotion corpus in No evaluator corpus scenarios matched this PR. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: befc3df565
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <script src="js/v3_signal_index.js"></script> | ||
| <script src="js/main.js"></script> | ||
| <script src="js/auto_update.bundle.js"></script> |
There was a problem hiding this comment.
When a vehicle is connected while an update is downloading on Windows, loading this bundle invokes downloadAndInstall(), whose bundled API documentation states that Windows exits the application after launching the installer (src/js/auto_update.bundle.js:218-245). Consequently, execution never reaches relaunchWhenIdle(), terminating the active diagnostic session and its keep-alive. Download the update first, wait until beeemuuIsConnected() is false, and only then install it.
AGENTS.md reference: AGENTS.md:L126-L130
Useful? React with 👍 / 👎.
This follow-up restores the full contents of the updater branch's three large files. The initial automated merge truncated these files while transferring the patch through GitHub's file API. The corrected contents match the local feature commit; this PR contains no additional scope.
Validation: JavaScript and Python suites passed locally, config validation and updater bundle generation passed. Rust tests need CI because the local machine lacks
libdbus-1-dev.