docs(adr): ADR-049 Amendment 2 - graduated fail-loud fallback policy#983
Merged
Conversation
Supersedes the unconditional local-dispatch fallback mandate in Decision section 2 with the shipped graduated policy: reason-coded fallback tiers (no-daemon quiet, rollout-transient WARN, illegitimate ERROR + strict rejection under KHIVE_DAEMON_STRICT=1) and fail-loud respawn_failed for positively observed daemon-recovery failures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
oceanwaves630
approved these changes
Jul 14, 2026
oceanwaves630
left a comment
oceanwaves630
left a comment
Collaborator
There was a problem hiding this comment.
Amendment 2 reviewed in full: graduated reason-coded policy, strict-mode semantics, and the confirmed-respawn rejection contract are coherent with the merged fail-loud direction, and the caller-visible error correctly excludes spawn detail. Approved.
ohdearquant
marked this pull request as ready for review
July 14, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amends ADR-049's Decision section 2, whose unconditional mandate ("Fallback to local dispatch is mandatory ... never a hard dependency") was never updated when the graduated fail-loud fallback shipped (bba4c4a). This amendment records the contract the code now implements:
FallbackReasonset with stable string codes (config_mismatch,namespace_mismatch,no_socket,parse_failure,protocol_mismatch) and legitimacy tiers governing quiet/WARN/ERROR observability.KHIVE_DAEMON_STRICT=1rejects any would-be fallback with a structured, marker-carrying error (default off).respawn_failederror in both modes instead of silently serving cold local dispatch; detailed context goes to local structured logging only.KHIVE_NO_DAEMON=1remains the sanctioned daemonless opt-out; genuinely daemonless environments keep quiet fallback.Sequencing
Docs-only. Lands before/with #963 so its daemon-path changes are re-gated against the amended contract rather than the stale section-2 mandate.
🤖 Generated with Claude Code