Skip to content

fix(db): tx_age_sweep flaky test race (#926)#975

Merged
ohdearquant merged 12 commits into
mainfrom
fix-926-tx-sweep-flake
Jul 14, 2026
Merged

fix(db): tx_age_sweep flaky test race (#926)#975
ohdearquant merged 12 commits into
mainfrom
fix-926-tx-sweep-flake

Conversation

@ohdearquant

Copy link
Copy Markdown
Owner

Addresses #926 — tx_age_sweep_names_long_lived_reader_pinning_wal_past_high_water races concurrently registered tx entries.

Implementer leg completed the change but stalled before commit (shared build-lane contention); swept and pushed by the lane owner. Local gates deferred to CI; codex review follows.

🤖 Generated with Claude Code

Leo and others added 11 commits July 13, 2026 12:54
Commit-early sweep: implementer leg ended without committing (build-lane
contention). Local gates deferred to CI.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ky tx-age sweep

run_writer_task registers a writer_task_tx handle in the process-wide
tx_registry singleton; the checkpoint tx_age_sweep_* tests read that
singleton under #[serial(tx_registry)]. The writer_task.rs tests that
spawn a writer task were missing from the group, leaking a longer-lived
writer_task_tx into the sweep's oldest() read and intermittently failing
the assertion on main CI. Join them to the serial group. No prod change.
Merge main and drop implementation_notes.md, a stray process-notes file
that does not belong in the source tree.
@ohdearquant ohdearquant marked this pull request as ready for review July 14, 2026 19:34
# Conflicts:
#	crates/khive-db/src/checkpoint.rs
@ohdearquant ohdearquant enabled auto-merge (squash) July 14, 2026 20:07
@ohdearquant ohdearquant merged commit c29e894 into main Jul 14, 2026
23 checks passed
@ohdearquant ohdearquant deleted the fix-926-tx-sweep-flake branch July 14, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants