feat(pack-kg): served-result telemetry on search#973
Merged
Conversation
Commit-early sweep: implementer leg ended without committing (build-lane contention). Local gates deferred to CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ky tx-age sweep run_writer_task registers a writer_task_tx handle in the process-wide tx_registry singleton; the checkpoint tx_age_sweep_* tests read that singleton under #[serial(tx_registry)]. The writer_task.rs tests that spawn a writer task were missing from the group, leaking a longer-lived writer_task_tx into the sweep's oldest() read and intermittently failing the assertion on main CI. Join them to the serial group. No prod change.
Merge main and drop implementation_notes.md, a stray process-notes file that does not belong in the source tree.
Catch feat-806 up to main (through #960/#970/#992). Sole conflict was the khive_storage import in crates/khive-pack-kg/tests/integration.rs; resolved by union: {Edge, EdgeRelation, Note, SqlStatement, SqlValue}. Also apply codex round-1 fixes (APPROVE-WITH-FIXES, both Low): - khive-db event_tests: add search_executed_rejects_absent_result_kind, covering the absent-result_kind rejection + atomic rollback (round 1 only tested an unknown result_kind value). - khive-runtime integration: correct stale decode_recall_observations comment to decode_search_observations and document the result_kind (entity|note) substrate discriminator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ohdearquant
marked this pull request as ready for review
July 17, 2026 13:48
ohdearquant
enabled auto-merge (squash)
July 17, 2026 13:48
oceanwaves630
approved these changes
Jul 17, 2026
oceanwaves630
left a comment
oceanwaves630
left a comment
Collaborator
There was a problem hiding this comment.
Full diff read: result_kind discriminator fixes the entity-as-Note projection gap with fail-closed rejection and atomic rollback tested both directions; emission mirrors the recall seam off the response path; exactly-one-event and full projection round-trip pinned for both kinds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #806.
Implementer leg completed the change set but stalled before commit (shared build-lane contention); swept and pushed by the lane owner. Local gates deferred to CI; codex review follows.
🤖 Generated with Claude Code