feat(pack-kg): ADR-086 document entity_type governed vocabulary#688
Draft
ohdearquant wants to merge 1 commit into
Draft
feat(pack-kg): ADR-086 document entity_type governed vocabulary#688ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
Adds the ADR-086 document entity_type governed set (spec, note, summary, handoff, report, reference, adr, transcript, other) to khive-pack-kg's existing EntityTypeRegistry — a Modify per PI_AEP, no new pack, table, or verb. spec and report already resolved via the pre-existing specification alias and report entry, so only note/summary/handoff/reference/adr/ transcript/other are newly registered. Covers both the registry's own resolve() unit tests and end-to-end create/search/list dispatch tests confirming: each governed value is accepted on document create, an ungoverned value is rejected fail-closed with the valid values listed, entity_type is optional (omission accepted), and the existing entity_type filter path on search/list already scopes document results without any new filter surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ADR-086 (document/file modeling) v1: registers the governed document
entity_type vocabulary in the existing EntityTypeRegistry.
Changes
reference, adr, transcript, other.
specandreportare deliberately not re-declared:specalready resolvesthrough the pre-existing
specificationalias (create/list/search canonicalizebefore storage and filtering, so
entity_type="spec"round-trips correctly),and
reportwas already a canonical Document subtype.Validation
rejected fail-closed with the valid value list.
Tests
create/search/list dispatch (accept each governed type, reject ungoverned with
value list, omitted accepted, search/list filtering by entity_type).
Refs: docs/adr/ADR-086-doc-file-pack.md