Stop the node_id placeholder looking like a real node - #41
Closed
Purple10101 wants to merge 1 commit into
Closed
Purple10101 wants to merge 1 commit into
Purple10101 wants to merge 1 commit into
Conversation
network.node_id shipped as "ret000000000", which is close enough to a real id to be read as a live node in a config dump while being identical on every node in the fleet. It matches neither the ret + 8 hex format nor the retg + 15 hex one that replaces it. config-merger overwrites this from /data/mender/node_id on every merge and nothing derives an identity from node config, so the value is only ever a placeholder between first boot and the first merge. "unset" says that. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing: this work is not being taken forward. The branch is deleted, but the commits stay reachable from this closed PR if it is ever revived. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 5, with owl-os#59, retina-telemetry#20, node-infra#8 and retina-gui#93. The smallest of the five.
Why
network.node_idshipped as"ret000000000". That is close enough to a real id to be read as a live node in a config dump, while being identical on every node in the fleet. It also matches neither format: notret+ 8 hex, and not theretg+ 15 hex that replaces it.config-mergeroverwrites this from/data/mender/node_idon every merge, and nothing derives an identity from node config, so the value is only ever a placeholder between first boot and the first merge."unset"says that, and the comment explains why it deliberately does not look like an id.retina-telemetry's
collect/identity.pycarries a landmine note about this exact string; that note is updated in retina-telemetry#20.Verified
Both config files parse,
network.node_idreads'unset', and nothing in the repo references the old value.Not verified
The
config-mergertest suite does not run here —mergedeepis not installed in this environment. Pre-existing, unrelated to this change, and the change is one value plus a comment in a default config that nothing reads for identity.Note for the reviewer
TELEMETRY_Vis not bumped here. That comes in Wave 1 of the rollout, once retina-telemetry#20 has been tagged and published to GHCR.🤖 Generated with Claude Code