Repository navigation
20260923 - One Send link button for the node claim - #96
Merged
Merged
Conversation
Reported on jonathan-node-1 (ClickUp 123zgec4mb1): after releasing the node from the dashboard, neither Save nor Send again produced a claim link. Save was the trap. Saving an address the node already held wrote an identical file, so retina-telemetry could not see the press and sent nothing. After a release that was the whole story: the address never changed, so Save could never ask again. The claim section now has one button, Send link, and every press stamps send_requested_at beside the address. One press is one email, whatever state the claim is in, and nothing is sent without one. retina-telemetry still chooses the call: a changed address is a PUT, the same address is a resend, and the same address on a released node is a PUT again (offworldlabs/retina-telemetry#22). - An empty box on Send removes the record, as an empty Save did. - The button is disabled while the node reads Owned, where a resend is refused and a new address would be offering somebody else's node. - The route loses its resend flag and the save no longer carries an old stamp forward, since there are no ordinary saves left for it to protect. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the claim section's Save and Send again with a single Send link button. The other half of Unclaim & Reclaim Fail, with offworldlabs/retina-telemetry#22.
Why
On jonathan-node-1 the owner released the node from the dashboard, then neither button produced a link.
Save was the trap. Saving an address the node already held wrote an identical file, so retina-telemetry could not see the press and sent nothing. After a release the address never changes, so Save could never ask again. Send again reached the node but was a resend, and a release clears the address a resend mails to. retina-telemetry#22 fixes that half.
What changes
Every press of Send link stamps
send_requested_atbeside the address. One press is one email, whatever state the claim is in, and nothing is sent without a press. The node still decides the call, as before:PUT /nodes/claim(the stamp beside it counts as answered)POST /nodes/claim/resendPUT /nodes/claim(needs retina-telemetry#22)/set-up/claimloses itsresendflag and therequestedkey in its answer. The page was their only caller.save_telemetry_claimlosesrequest_sendand no longer carries an old stamp forward, since there are no plain saves left for that to protect.Order of release
Either order is safe. With this and a retina-telemetry that lacks #22, the only case still broken is the released node, exactly as today. #22 without this fixes Send again but leaves Save as a silent no-op after a release.
Verification
ruff check .,pre-commit run --all-filesand the fullpytestsuite (942) pass, run on a clean checkout oforigin/mainplus this change.🤖 Generated with Claude Code