Repository navigation
20261014 - Put Controller last on Home and say how much the Tracker keeps - #117
Conversation
Purple10101
left a comment
Purple10101
left a comment
There was a problem hiding this comment.
Looks good. The card order and the "up to 4 hours" wording match what the Tracker sidecar keeps (MAX_VIEW_WINDOW_S, tracker.md#view-window). I've also seen it on a test node's Home page.
One thing to sort out before this merges: the commit's authorship is odd. It is authored as Claude <noreply@anthropic.com>, where every commit on main is authored by a person with Claude as Co-Authored-By, and it carries a Claude-Session: trailer that no commit on main has. Please re-author it as yourself and drop the session trailer.
…eeps Home listed Controller third, between the live radar views and the map. Controller is the way into everything the other cards do not cover, so it reads better as the last card: Passive Radar, Max-Hold, ADS-B Map, Tracker, Controller. The Tracker card now says it keeps up to 4 hours of history. tests/test_home_services.py is new and holds the order and the Tracker wording. Docs: architecture.md (Home's service cards). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AoHZhvWU7Ge89Cm6YgrExB
ba7ef10 to
bbef15f
Compare
|
Note on attribution: this PR is Jonathan Fremerman's (@jfremerman). It was opened through a shared Claude account that is signed in as @kazad, so GitHub lists that account as the opener. The commits have been re-authored under @jfremerman, who directed, tested on hardware and signed off each change, with the Co-Authored-By trailer recording Claude's part. Nothing here was created unsupervised. Generated by Claude Code |
Split out of #113 at the reviewer's request (3 of 4). Same code as commit f498ced there, rebased onto current
main.What
Home's service cards run Passive Radar, Max-Hold, ADS-B Map, Tracker, Controller, and the Tracker card says it keeps up to 4 hours of history.
Why
Controller sat third, between the live radar views and the map. It is the way into everything the other cards do not cover, so it reads better last. How much history the Tracker keeps is the first thing an owner asks about it.
Testing
test_an_unwritable_location_reports_rather_than_raises, the root-only sandbox failure that also fails on untouchedmain).ruff check .and the vulture hook pass.tests/test_home_services.pyholds the order and the Tracker wording.Docs
docs/architecture.md(Home's service cards).🤖 Generated with Claude Code
https://claude.ai/code/session_01AoHZhvWU7Ge89Cm6YgrExB
Generated by Claude Code