Repository navigation
Conversation
This was referenced Oct 14, 2026
kazad
force-pushed
the
20261014-config-page-groups
branch
from
October 14, 2026 17:14
7782205 to
8621e28
Compare
Author
|
Note on attribution: this PR is Jonathan Fremerman's (@jfremerman). It was opened through a shared Claude account that is signed in as @kazad, so GitHub lists that account as the opener. The commits have been re-authored under @jfremerman, who directed, tested on hardware and signed off each change, with the Co-Authored-By trailer recording Claude's part. Nothing here was created unsupervised. Generated by Claude Code |
The Configuration page had grown a section at a time, and its order no longer matched how an owner works through a node. Node Claim sat near the bottom of a long Administration group, the centre frequency lived in Capture while the tower it belongs to was two sections up, and the side menu's group headings looked the same as the links under them. The page is now five groups: Node (Identifiers, Mode, Node Claim, Network), Radar (Cached Towers, Tower, Capture, Tracking), ADS-B (ADS-B Truth, tar1090), Other (SSH Access, Setup Wizard) and Support (Cloud Services, Remote Support, How We Reach You). Each group is titled in the page itself with a rule running out to the right, the side menu's group titles carry the same rule, and a section has one name, written the same in the menu, in its heading and in the wizard hints that point at it. What was "Tower" is "Cached Towers" and what was "Location" is "Tower". Center Frequency moves into Tower's transmitter block, after Name, because it is a property of the tower and not of the capture. Tower shows the receiver's name read-only; it is changed under Identifiers, which also shows the server's identifier for the node beside the local one. The form Apply changes submits now wraps exactly the Radar and ADS-B groups. That is the property the regrouping must not break: a radar field left outside the form is missing from the POST, which the server reads as that setting having been cleared. tests/test_config_layout.py is new and holds the order, the group titles, the form's membership and the centre frequency's new home. test_app.py, test_claim.py, test_contact.py and test_node_name.py follow the renamed sections. Docs: config-editor.md gains a Page layout section and uses the new names throughout; setup-wizard.md, device-state-and-telemetry.md and remote-access.md follow the renames. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AoHZhvWU7Ge89Cm6YgrExB
kazad
force-pushed
the
20261014-config-page-groups
branch
from
October 15, 2026 14:23
8621e28 to
8ef34f5
Compare
Contributor
|
Re-opened as #119 under @jfremerman so the PR and the commits carry the same author, as requested. Same branch and code. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #113 at the reviewer's request (1 of 4). Same code as commit 3206489 there, rebased onto current
main.What
The Configuration page is regrouped around how an owner works through a node: Node (Identifiers, Mode, Node Claim, Network), Radar (Cached Towers, Tower, Capture, Tracking), ADS-B (ADS-B Truth, tar1090), Other (SSH Access, Setup Wizard) and Support (Cloud Services, Remote Support, How We Reach You).
Why
The page had grown a section at a time and its order no longer matched how a node is set up and tuned: Node Claim sat near the bottom of a long Administration group, the centre frequency lived in Capture while the tower it belongs to was two sections up, and the side menu's group headings looked the same as the links under them. The guided tutorial (coming as a separate PR) walks this page top to bottom, so the order had to make sense first.
The change
tests/test_config_layout.pyholds this.Testing
tests/test_node_name.py::test_an_unwritable_location_reports_rather_than_raises, which fails in the sandbox the suite ran in because it runs as root there, and fails the same way on untouchedmain.ruff check .and the vulture hook pass.tests/test_config_layout.py.test_app.py,test_claim.py,test_contact.pyandtest_node_name.pyfollow the renamed sections.mainhas not been on hardware.Docs
docs/features/config-editor.md(new Page layout section, renamed sections),docs/features/setup-wizard.md,docs/features/device-state-and-telemetry.mdanddocs/features/remote-access.md(renamed sections).🤖 Generated with Claude Code
https://claude.ai/code/session_01AoHZhvWU7Ge89Cm6YgrExB
Generated by Claude Code