Repository navigation
20260928 - Show the server's reason when the contact step is refused - #103
Merged
Merged
Conversation
postJSON rejects on any non-2xx response and dropped the per-field errors, so the contact step's refusal branch never ran and a bad country code (such as a single letter) read as a connection failure. The rejected error now carries the errors, and the contact step shows the first one. The postJSON change is identical to the one in #102, so the two merge cleanly in either order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The wizard's Contact details step showed "Could not save. Check the connection and try again." for every refusal, including a bad country code such as
UorG1, instead of the server's own message.Why
postJSONinstatic/setup.jsrejects on any non-2xx response and dropped the server's per-fielderrors. So the step's!data.successbranch never ran, and every 400 fell through to the connection-error catch.Fix
failure()now attaches the response'serrorsto the rejected error.This is the same fix #102 applies to the new claim step. The
postJSONchange is identical in both PRs, so they merge cleanly in either order.Testing
🤖 Generated with Claude Code