Repository navigation
Default the standalone Doppler span to +/-1000 Hz, matching the fleet - #82
Merged
Merged
Conversation
…g the fleet retina-node now runs every node at +/-1000 Hz (offworldlabs/retina-node#49). config/config.yml is only the standalone and development default, so it moves to match and a local run sees the same geometry as a node. Adds Constructor_Round_Shipped to TestAmbiguity at that geometry: 1001 Doppler bins, nCorr 999, nfft 1997 rounded to 2000 (2^4 * 5^3, so no badly factored FFT length), and the 411-bin delay window inside nCorr. The existing +/-300 cases stay as they are. Corrects the CFAR comment that quoted the +/-300 map as the shipped geometry. Verification: TestAmbiguity built and run on x86 (gcc, FFTW 3), 4 passed and the existing file-replay case skipped for want of its capture file. Changing the expected bin count to 1000 fails the new case. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes blah2's standalone default match the fleet's Doppler span, +-1000 Hz, set in offworldlabs/retina-node#49. It changes nothing on deployed nodes, which build their config from retina-node's
default.yml.config/config.ymlonly affects standalone and development runs, so a local run now sees the same geometry as a node.Changes
config/config.yml:dopplerMin/dopplerMaxchange from -300/300 to -1000/1000.TestAmbiguity.cpp: newConstructor_Round_Shippedcase at the shipped geometry, which checks:The existing +-300 cases are unchanged.
CfarDetector1D.cpp: corrects a comment that quoted the +-300 map (123,711 cells) as the shipped geometry.Verification
TestAmbiguitywas built and run on x86 (gcc, FFTW 3): 4 passed. The existing file-replay case skipped because its capture file is missing.Docs
None changed. README and CLAUDE.md don't state the span.
🤖 Generated with Claude Code