Sync feedback: Desktop chat, model, and preview fixes

.github/workflows/ci.yml

@@ -64,10 +64,9 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: '24' # node:sqlite (used by integration tests) is available unflagged
-      # @offgrid/sync is a file: dependency on the SIBLING shared monorepo ("file:../shared/packages/sync").
-      # It arrived with the sync work and CI never provisioned it, so every job that installs would fail on the
-      # same missing module. actions/checkout refuses a path outside the workspace, so it lands inside and is
-      # moved up one level - exactly where the file: specifier points.
+      # Shared packages are file: dependencies on the SIBLING shared monorepo. CI must provision it before
+      # installing Desktop. actions/checkout refuses a path outside the workspace, so it lands inside and is
+      # moved up one level - exactly where the file: specifiers point.
       #
       # Matching branch first, main as the fallback, the same shape as the pro checkout above: a PR that changes
       # the app and the shared package together must be tested against the package it expects.
@@ -93,7 +92,7 @@ jobs:
       - name: Put shared beside this checkout
         run: |
           if [ ! -d _shared ]; then
-            echo "::error::off-grid-ai/shared was not checked out - @offgrid/sync cannot resolve. Check CI_CROSS_REPO_TOKEN."
+            echo "::error::off-grid-ai/shared was not checked out - shared packages cannot resolve. Check CI_CROSS_REPO_TOKEN."
             exit 1
           fi
           rm -rf ../shared
@@ -107,6 +106,7 @@ jobs:
           # later gates run against dependencies nobody committed. A drifted lock should stop the build.
           npm --prefix ../shared ci
           npm --prefix ../shared/packages/sync run build
+          npm --prefix ../shared/packages/models run build
       - run: npm ci
       # Hard gates: types + the full test suite.
       - name: Typecheck (core)

.github/workflows/release.yml

@@ -125,7 +125,7 @@ jobs:
       - name: Build llama-server (pinned deployment target)
         run: |
           command -v cmake >/dev/null || brew install cmake
-          MACOS_DEPLOYMENT_TARGET=13.0 LLAMA_REF=b9838 bash scripts/build-llama.sh
+          MACOS_DEPLOYMENT_TARGET=13.0 bash scripts/build-llama.sh
           otool -l resources/bin/llama/llama-server | awk '/LC_BUILD_VERSION/{f=1} f&&/minos/{print "[ci] bundled engine minos="$2; exit}'
       # Rebuild the one-shot Whisper CLI instead of trusting the committed LFS
       # payload. The production script disables OpenMP/BLAS auto-discovery and
@@ -189,7 +189,7 @@ jobs:
         with:
           node-version: '20'
           cache: 'npm'
-      # `@offgrid/sync` is a file: dependency on the shared monorepo, so it must sit BESIDE this
+      # Shared packages are file: dependencies on the shared monorepo, so it must sit BESIDE this
       # checkout before `npm ci` runs - an install cannot resolve a path that does not exist, and the
       # typecheck inside `npm run build` then fails on every import of it. `ci.yml` has done this since
       # the sync work landed; this workflow did not, which is why no release has built since 2026-07-30.
@@ -218,7 +218,7 @@ jobs:
       - name: Put shared beside this checkout
         run: |
           if [ ! -d _shared ]; then
-            echo "::error::off-grid-ai/shared was not checked out - @offgrid/sync cannot resolve. Check CI_CROSS_REPO_TOKEN."
+            echo "::error::off-grid-ai/shared was not checked out - shared packages cannot resolve. Check CI_CROSS_REPO_TOKEN."
             exit 1
           fi
           rm -rf ../shared
@@ -228,6 +228,7 @@ jobs:
           # drifted lock stops the release instead of resolving a graph nobody committed.
           npm --prefix ../shared ci
           npm --prefix ../shared/packages/sync run build
+          npm --prefix ../shared/packages/models run build
       - name: Install dependencies
         run: npm ci
       # Stamp the resolved version into package.json so electron-builder picks the
@@ -426,7 +427,7 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: '3.12'
-      # `@offgrid/sync` is a file: dependency on the shared monorepo, so it must sit BESIDE this
+      # Shared packages are file: dependencies on the shared monorepo, so it must sit BESIDE this
       # checkout before `npm ci` runs - an install cannot resolve a path that does not exist, and the
       # typecheck inside `npm run build` then fails on every import of it. `ci.yml` has done this since
       # the sync work landed; this workflow did not, which is why no release has built since 2026-07-30.
@@ -458,7 +459,7 @@ jobs:
         shell: bash
         run: |
           if [ ! -d _shared ]; then
-            echo "::error::off-grid-ai/shared was not checked out - @offgrid/sync cannot resolve. Check CI_CROSS_REPO_TOKEN."
+            echo "::error::off-grid-ai/shared was not checked out - shared packages cannot resolve. Check CI_CROSS_REPO_TOKEN."
             exit 1
           fi
           rm -rf ../shared
@@ -468,6 +469,7 @@ jobs:
           # drifted lock stops the release instead of resolving a graph nobody committed.
           npm --prefix ../shared ci
           npm --prefix ../shared/packages/sync run build
+          npm --prefix ../shared/packages/models run build
       - name: Install dependencies
         run: npm ci
       - name: Fetch Windows native binaries (llama/whisper/sd/ffmpeg)

.gitignore

@@ -36,9 +36,11 @@ resources/bin/proximity-helper
 # TS build cache
 *.tsbuildinfo
 
-# Private pro features — separate repo, added as a git submodule once the remote
-# exists. Ignored for now so the open repo never tracks pro source.
-/pro/
+# Private pro features — a separate repo, tracked as a git submodule now that the remote exists.
+# The submodule records only a URL and a commit, so this open repo still never carries pro source -
+# while pinning exactly which pro revision belongs with this branch. NOT ignored any more: while it
+# was, six licensing tests under pro/ stayed tracked here AND in desktop-pro, so an edit showed up in
+# both repos and the two could diverge with no signal.
 
 # Vendored @offgrid packages ship their built dist
 !packages/*/dist/

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "pro"]
+	path = pro
+	url = https://github.com/off-grid-ai/desktop-pro.git

docs/GAPS_BACKLOG.md

@@ -7,6 +7,20 @@ how to reproduce, and the fix direction. Close with evidence; never hide.
 
 ## OPEN
 
+### SYN-004 (P1) - Late-pair full graph is not verified between the real Desktop and Mobile apps
+
+**Evidence (2026-08-13):** the production send paths now backfill state records, generated images,
+message attachments, and knowledge documents when a device pairs after the data exists. Shared tests
+prove byte-bounded anti-entropy. Desktop tests use the real service, SQLite, and temporary files.
+Mobile tests use two real sync engines and prove exact file bytes and durable controls. These tests do
+not start both actual apps and verify final receiver materialization and UI in one journey.
+
+**Evidence required to close:** create a project, settings, chat text, enhanced prompt, reasoning,
+completed tool, generated image, attachment, and knowledge document on device A before device B is
+paired. Pair the real apps through the production connect path. Verify every record, relationship,
+and byte on B, restart B, and verify that the same graph returns without duplicate transfers or
+detached files. Run Desktop-to-Mobile and Mobile-to-Desktop on physical macOS, iOS, and Android.
+
 ### DEF-001 (P1) - Replay capture control reports a state that is not factual
 
 **Evidence (2026-08-08):** macOS Settings reported `Screen access: denied` and `Permission
@@ -1181,3 +1195,77 @@ Independently: `0 failed` next to a logged `request.failed` is its own bug - the
 reaching Activity even for the file that DID have a row.
 
 ---
+
+## MTP is a mobile feature, and it should be a `@offgrid/models` one
+
+**Status:** open. Filed 2026-08-12. Deliberately NOT in the current PR - it is a package extraction,
+not a fix, and folding it in would bloat a release branch that is about sync feedback.
+
+**The gap.** MTP support exists on mobile and does not exist on desktop. Both apps consume the same
+model layer, so a capability that lives in one app's screens is a rule with one home and two
+audiences - the shape this repo keeps finding at the root of its bugs.
+
+**Why it is a shared-package problem, not a desktop one.** Copying the mobile implementation across
+would make it a rule with TWO homes, which is worse than having it once. The model layer is the owner:
+whether a model needs MTP, which artefacts it implies, and how a device advertises support are all
+properties of the MODEL, and every surface should be asking `@offgrid/models` rather than each app
+deciding for itself. Desktop then gets it by consuming the package, and so does any future surface.
+
+**Fix shape.**
+
+1. Move the MTP capability rule into `shared/packages/models` - one definition of what MTP is and which
+   models require it, keyed off the catalog entry, with no app-specific branching inside it.
+2. Mobile stops deciding and starts asking. Its current behaviour is the reference for what the rule
+   must produce, so it is the regression check that the extraction changed nothing.
+3. Desktop consumes the same rule. No `if (platform)` in either app: a platform that cannot serve MTP
+   reports that through the same interface, it does not get a special case at the call site.
+
+**Watch for:** the mobile implementation almost certainly carries assumptions that are really about the
+phone runtime rather than about MTP. Those belong on the platform adapter, not in the shared rule - and
+the tell is any code in the extracted package that names a platform.
+
+---
+
+## Every non-image attachment syncs to desktop as "text" and previews blank
+
+**Verdict:** fix-the-guard — the kinds exist, the write path never uses them.
+
+Reproduced on hardware 16 Aug 2026: a message sent from iPhone with three attachments (a camera
+photo, a library screenshot and `mobile.pdf`). On desktop the PDF arrives as a chip reading
+
+```
+mobile.pdf   text
+```
+
+and opening it shows an empty viewer with only Download and Close - nothing renders. Android shows
+the same message correctly, because it has its own renderer.
+
+The attachment type already names the kinds:
+
+```ts
+kind: 'text' | 'pdf' | 'docx' | 'image' | 'audio' | 'video'
+```
+
+but the write path in `src/renderer/src/components/MemoryChat.tsx` (~2940) only ever chooses between
+two of them:
+
+```ts
+if (isImage) { kind: 'image', code: a.path }
+else if (a.text) { kind: 'text', code: a.text }
+```
+
+A PDF has no image path, so it falls through to `text` and renders `a.text` - which for a binary
+document is empty. Hence a labelled-but-blank preview rather than an error.
+
+**This is not PDF-specific.** Any non-image attachment takes the same branch. It was predicted from
+the v0.0.103 diff for VOICE NOTES - "Mac classifies any non-image as kind: 'text', so a .wav arrives
+as a paperclip chip labelled text, and clicking it opens a blank viewer" - and never reproduced until
+now. A PDF and a voice note are the same bug.
+
+**Why it matters:** the attachment did sync. The bytes are there (Download works). What is broken is
+the classification and therefore the rendering, so the user sees a file they cannot open and
+concludes the transfer failed.
+
+**Fix:** classify by MIME/extension into the kinds the union already declares, carry `path` for
+binary kinds rather than `text`, and render a PDF/document viewer for them. `src/main/mime.ts`
+already exists and is the obvious source of truth.

docs/WINDOWS_SUPPORT.md

@@ -31,7 +31,7 @@ at the bottom.
 | -------------------------------- | ------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | Windows CI build                 | 🟢     | `.github/workflows/windows-build.yml` (`windows-2022`) builds + packages a branch artifact; `release.yml`'s `build-win` job publishes the installer + updater feed to the release. Verified by installing a build on real Windows hardware.                                                                                                                                                                                                          |
 | Native-module compile (node-gyp) | 🟢     | Pinned toolchain: `windows-2022` (VS 2022) + Python 3.12. `windows-latest`/VS 2026 + Python 3.13 break node-gyp 11 — documented in the workflow. Covers `better-sqlite3-multiple-ciphers`, `node-llama-cpp`, `sharp`.                                                                                                                                                                                                                                |
-| Windows runtime binaries fetch   | 🟢     | `scripts/fetch-win-binaries.ps1` pulls win64 `llama-server` / `whisper-cli` / `sd-cli` / `ffmpeg` (+ DLLs) from upstream GitHub releases at build time. **`llama-server` is pinned to `b9838`** (byte-for-byte parity with the macOS engine); `whisper-cli` / `sd-cli` / `ffmpeg` resolve dynamically from their latest upstream releases. Repo LFS binaries are macOS-only and skipped (`lfs: false`). Fails loud if `llama-server.exe` is missing. |
+| Windows runtime binaries fetch   | 🟢     | `scripts/fetch-win-binaries.ps1` pulls win64 `llama-server` / `whisper-cli` / `sd-cli` / `ffmpeg` (+ DLLs) from upstream GitHub releases at build time. **`llama-server` is pinned by `package.json` `offgrid.llamaRef`**. macOS compiles it; Windows gets the same-revision prebuilt, so bytes can differ. `whisper-cli` / `sd-cli` / `ffmpeg` resolve dynamically from their latest upstream releases. Repo LFS binaries are macOS-only and skipped (`lfs: false`). Fails loud if `llama-server.exe` is missing. |
 | NSIS installer                   | 🟢     | `electron-builder.yml` → `win.executableName`, `nsis` block (desktop shortcut, uninstall name). Untested end-to-end.                                                                                                                                                                                                                                                                                                                                 |
 | Code signing                     | 🟡     | Optional via `WIN_CSC_LINK` / `WIN_CSC_KEY_PASSWORD` secrets; **unset → unsigned build → SmartScreen will warn** on install. No cert configured yet.                                                                                                                                                                                                                                                                                                 |
 | Auto-update                      | 🟢     | `electron-updater` is cross-platform (`src/main/updater.ts`); `release.yml`'s `build-win` job publishes `latest.yml` (stable) / `beta.yml` (nightly) to the release, so Windows installs self-update like macOS.                                                                                                                                                                                                                                     |

e2e/devices-sync.spec.ts

@@ -45,8 +45,8 @@
 let syntheticPeer: SyncEngine | null = null
 let syntheticState: StateSync | null = null
 let syntheticFiles: FileTransferManager | null = null
 let syntheticImportedEntitlement: unknown
 let syntheticEntitlementCommitted = false
 let syntheticClipboard: ClipboardSyncCoordinator | null = null
 const syntheticClipboardRecords = new Map<string, ClipboardHistoryRecord>()
 /** The peer's pending clipboard deliveries, keyed the way the coordinator keys them: record × device. */
@@ -518,7 +518,7 @@
     await page.getByRole('button', { name: 'Rescan network' }).click()
     await expect(page.getByRole('button', { name: 'Rescan network' })).toBeEnabled()
     await expect(page.getByText('Synthetic Android').first()).toBeVisible()
-    await expect(page.getByText('Scanning LAN and Nearby routes.')).toHaveCount(0)
+    await expect(page.getByText('Scanning WiFi and Nearby routes.')).toHaveCount(0)
     await expect(page.getByRole('alert')).toHaveCount(0)
 
     const timestamp = new Date().toISOString()