Skip to content

fix(release): the release build gets the shared monorepo it depends on #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alichherawalla merged 1 commit into from
Aug 11, 2026
Merged

fix(release): the release build gets the shared monorepo it depends on #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,45 @@ jobs:
with:
node-version: '20'
cache: 'npm'
# `@offgrid/sync` is a file: dependency on the shared monorepo, so it must sit BESIDE this
# checkout before `npm ci` runs - an install cannot resolve a path that does not exist, and the
# typecheck inside `npm run build` then fails on every import of it. `ci.yml` has done this since
# the sync work landed; this workflow did not, which is why no release has built since 2026-07-30.
#
# The release ref decides the shared ref: a release from `main` takes shared `main`, and a release
# from an integration branch takes the branch of the same name when one exists.
- name: Checkout shared at the matching ref
id: shared_branch
continue-on-error: true
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
repository: off-grid-ai/shared
token: ${{ secrets.CI_CROSS_REPO_TOKEN }}
ref: ${{ github.ref_name }}
path: _shared
persist-credentials: false
- name: Fall back to shared main
if: ${{ steps.shared_branch.outcome != 'success' }}
continue-on-error: true
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
repository: off-grid-ai/shared
token: ${{ secrets.CI_CROSS_REPO_TOKEN }}
path: _shared
persist-credentials: false
- name: Put shared beside this checkout
run: |
if [ ! -d _shared ]; then
echo "::error::off-grid-ai/shared was not checked out - @offgrid/sync cannot resolve. Check CI_CROSS_REPO_TOKEN."
exit 1
fi
rm -rf ../shared
mv _shared ../shared
# Install at the WORKSPACE ROOT: shared is an npm-workspaces monorepo whose lockfile and
# build tool live at the root, and packages/sync declares neither. A locked install, so a
# drifted lock stops the release instead of resolving a graph nobody committed.
npm --prefix ../shared ci
npm --prefix ../shared/packages/sync run build
- name: Install dependencies
run: npm ci
# Stamp the resolved version into package.json so electron-builder picks the
Expand Down Expand Up @@ -387,6 +426,45 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: '3.12'
# `@offgrid/sync` is a file: dependency on the shared monorepo, so it must sit BESIDE this
# checkout before `npm ci` runs - an install cannot resolve a path that does not exist, and the
# typecheck inside `npm run build` then fails on every import of it. `ci.yml` has done this since
# the sync work landed; this workflow did not, which is why no release has built since 2026-07-30.
#
# The release ref decides the shared ref: a release from `main` takes shared `main`, and a release
# from an integration branch takes the branch of the same name when one exists.
- name: Checkout shared at the matching ref
id: shared_branch
continue-on-error: true
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
repository: off-grid-ai/shared
token: ${{ secrets.CI_CROSS_REPO_TOKEN }}
ref: ${{ github.ref_name }}
path: _shared
persist-credentials: false
- name: Fall back to shared main
if: ${{ steps.shared_branch.outcome != 'success' }}
continue-on-error: true
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
repository: off-grid-ai/shared
token: ${{ secrets.CI_CROSS_REPO_TOKEN }}
path: _shared
persist-credentials: false
- name: Put shared beside this checkout
run: |
if [ ! -d _shared ]; then
echo "::error::off-grid-ai/shared was not checked out - @offgrid/sync cannot resolve. Check CI_CROSS_REPO_TOKEN."
exit 1
fi
rm -rf ../shared
mv _shared ../shared
# Install at the WORKSPACE ROOT: shared is an npm-workspaces monorepo whose lockfile and
# build tool live at the root, and packages/sync declares neither. A locked install, so a
# drifted lock stops the release instead of resolving a graph nobody committed.
npm --prefix ../shared ci
npm --prefix ../shared/packages/sync run build
Comment on lines +456 to +467

@greptile-apps greptile-apps Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Windows setup runs as PowerShell

When a release reaches build-win, this step runs under the Windows default PowerShell shell but uses Bash constructs such as if [ ... ], rm -rf, and mv, causing the step to fail before dependency installation and preventing Windows release artifacts from being produced.

- name: Install dependencies
run: npm ci
- name: Fetch Windows native binaries (llama/whisper/sd/ffmpeg)
Expand Down
Loading