feat: add DaemonStream abstraction for plain TCP and TLS connections#5075
Open
oferchen wants to merge 2 commits into
Open
feat: add DaemonStream abstraction for plain TCP and TLS connections#5075oferchen wants to merge 2 commits into
oferchen wants to merge 2 commits into
Conversation
Introduce DaemonStream enum that wraps either a plain TcpStream or a rustls TLS connection behind a unified Read + Write interface. All daemon call sites now accept DaemonStream instead of raw TcpStream, enabling transparent TLS upgrades when the daemon-tls feature is active. The TLS variant is gated behind #[cfg(feature = "daemon-tls")] so default builds pay zero cost. Includes wrap_accepted_stream() helper that performs TLS handshake or wraps as Plain based on TlsAcceptor availability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DaemonStreamenum (Plain(TcpStream)/Tls(StreamOwned)) that implementsRead + Write + DebugTcpStreamtoDaemonStream, enabling transparent TLS upgradeswrap_accepted_stream()helper that performs TLS handshake whenTlsAcceptoris configured#[cfg(feature = "daemon-tls")]- zero cost for default buildsTest plan
--features daemon-tlsCI cell validates TLS variant compilation