Repository navigation
fix disconnect and device names for bluez 5.87 - #1
Merged
Merged
Conversation
The disconnect message was renamed after 5.70, so disconnecting always looked like it failed. And 5.87 wraps devices that advertise as non-discoverable in color escapes that ended up in the name.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things that
update for bluz 5.87did not cover, found by comparing everyexpect()string against the 5.87 sources.The disconnect message was renamed after 5.70,
Successful disconnectedtoDisconnection successful, sodisconnect()always returnedFalse- the device did disconnect, but the plugin reported a failure. Both spellings are kept so the plugin still works against older bluez.print_devicegained a branch in 5.87 that wraps devices advertising as non-discoverable inCOLOR_BOLDGRAY:The block list catches
[NEW]style lines but not this one, so the escapes ended up in the parsed name - the normal case for a BLE remote. The escapes are now stripped before splitting; the existing filter is unaffected.The same two fixes are in oe-alliance-plugins/BTDevicesManager#1, which additionally needed the prompt change that this plugin already has.