Repository navigation
Fix the approval question and the session state, keep the viewer live - #1
Merged
Merged
Conversation
A participant renamed while the approval question was open was still asked for with the old name until the question timed out and counted as not approved. The question is now withdrawn and asked again with the new name. The screen and the indicator kept showing the access as approved after everybody approved had left, they are updated now when the approval is dropped. UP in the viewer on a terminal without history held its output back without showing it, so the view seemed to stop. It only pauses now when there is something to scroll back to.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues found while taking screenshots of a session on a receiver: