training-hoelg

[hossamelgendy1]

The R&D training real estate module

[robodoo]

[plha-odoo]

Good job for the quality of the code, for the styling and for using the proper commit message titles convention !
a few comments :

• We try to always leave an empty line at the end of every file.
  If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
• don't forget to add your ruff.toml and ruff.sh files in a gitignore file so it's not pushed in your remote branch

[hossamelgendy1]

Good job for the quality of the code, for the styling and for using the proper commit message titles convention ! a few comments :

• We try to always leave an empty line at the end of every file.
  If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
• don't forget to add your ruff.toml and ruff.sh files in a gitignore file so it's not pushed in your remote branch

Thanks for the feedback!

• Done with the first point.. nice to know the convention and the vscode feature!
• For the second point, yeah makes sense, but should I add them in my local .git/info/exclude to avoid cluttering the remote .gitignore file with developer-specific files? or .gitignore is fine?