-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[ADD] Real estate application #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
ac904f3 to
de075ba
Compare
- Created the estate module. - Created the EstateProperty model.
de075ba to
ff5d6b3
Compare
- Remvoed pylint error-ingoring commands. - Added Ruff config file for style check. - Reformated some files.
- Added security configuration for the estate module. - Fixes the warning message about the access rules.
- Added a simple test action to the estate module.
e3002a3 to
a2089f1
Compare
plha-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work for the overall quality of the code and syntax.
congrats on using the correct convention for the commit titles.
a few small comments :
- We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline. - make sure to add your ruff.toml file in a gitignore file so it's not pushed on your branch
| from datetime import date | ||
|
|
||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for blank lines between related imports
| from datetime import date | |
| from dateutil.relativedelta import relativedelta | |
| from datetime import date | |
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed!
Set up the general user interface for the estate app/module. - Added estate menu - Added action window - Set up the fields properties (required, default, etc..) - Added the `active` reserved field to the view
fdca6dc to
3f06a7a
Compare

EstatePropertymodel.