Skip to content

Conversation

@waterflow80
Copy link

@waterflow80 waterflow80 commented Jan 19, 2026

  • Created the estate module.
  • Created the EstateProperty model.

@robodoo
Copy link

robodoo commented Jan 19, 2026

Pull request status dashboard

@waterflow80 waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from ac904f3 to de075ba Compare January 19, 2026 16:10
@waterflow80 waterflow80 changed the title [ADD] Setup real estate application [ADD] Real estate application Jan 19, 2026
- Created the estate module.
- Created the EstateProperty model.
@waterflow80 waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from de075ba to ff5d6b3 Compare January 19, 2026 16:28
- Remvoed pylint error-ingoring commands.
- Added Ruff config file for style check.
- Reformated some files.
- Added security configuration for the estate module.
- Fixes the warning message about the access rules.
- Added a simple test action to the estate module.
@waterflow80 waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from e3002a3 to a2089f1 Compare January 20, 2026 13:37
Copy link

@plha-odoo plha-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work for the overall quality of the code and syntax.
congrats on using the correct convention for the commit titles.
a few small comments :

  • We try to always leave an empty line at the end of every file.
    If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
  • make sure to add your ruff.toml file in a gitignore file so it's not pushed on your branch

Comment on lines 1 to 2
from datetime import date

from dateutil.relativedelta import relativedelta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for blank lines between related imports

Suggested change
from datetime import date
from dateutil.relativedelta import relativedelta
from datetime import date
from dateutil.relativedelta import relativedelta

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

Set up the general user interface for the estate app/module.

- Added estate menu
- Added action window
- Set up the fields properties (required, default, etc..)
- Added the `active` reserved field to the view
@waterflow80 waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from fdca6dc to 3f06a7a Compare January 20, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants