zavan - Technical Training #1131
Conversation
|
|
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
good job, for the commit title and message, you can (for the next commits) follow these guidelines https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
Imported the right modules and fixed some typos. The estate_property table now shows up in PostgresSQL :D
MAGREMENT
changed the title
Fixed typo for in acces rights file
Made the basic menus, added the Properties action and edited the properties
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
Good job for the commit titles and the general quality of the code.
just a nitpick:
We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
Created the list, form & search views
Added all the models & the links
To comply with the CI/CD
Compute, inverse & onchange
Fixed a bug where creating a new offer was not possible due to create_date property sometimes being a bool
Accept & Refuse offers + Sell & Cancel properties
Added contraints
|
There is an error in the commit for the chapter 6. The filter's domain is not right. It is fixed in the commit for the chapter 11 |
Added all features except default search
|
The default search now works even though i did not change a thing. I am confusion |
Added the business logic to the CRUD methods. Waiting for help for the rest
Found the bug in Chapter 12
csan-odoo
left a comment
csan-odoo
left a comment
There was a problem hiding this comment.
Great work overall! Just a few small suggestions.
Also when looping over records, try to use more descriptive variable names. For example, instead of using "r", consider using "offer" or "property". This makes the code easier to read and understand.
Added kanban view to estate properties
Some, but not all style fixes
Fixed some styling issue and reverted the sql constraints change because it is no longer supported
The features of the 14 execercises of the chapter 1
4 participants
No description provided.