Skip to content

Conversation

@WaleedElgamal
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Jan 19, 2026

Pull request status dashboard

Copy link

@artn-odoo artn-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start !
Try to always add a description to describe your commit as it will make it easier for others to understand what you did.

Storing informtion related to properties in the module which will be mapped by ORM to a database table
Defining the access rights to the 'property' model
Define the author and license in manifest file
@artn-odoo artn-odoo requested a review from csan-odoo January 21, 2026 08:56
Created three menus which are linked to a a single action which creates a new property
Create custom search, list and form views for the properties with filter and group by options
Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a few minor nitpicks

'depends': ['base'],
'data': [
'security/ir.model.access.csv',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to leave an empty space here

Suggested change

@@ -0,0 +1,2 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_estate_property,estate.property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline.

<menuitem id="estate_menu_properties" action="estate_property_action"/>
</menuitem>
</menuitem>
</odoo> No newline at end of file
Copy link

@csan-odoo csan-odoo Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

<field name="res_model">estate.property</field>
<field name="view_mode">list,form</field>
</record>
</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants