adding real estate module #1128
Conversation
|
|
artn-odoo
left a comment
artn-odoo
left a comment
There was a problem hiding this comment.
Nice job so far !
Just some small styling nitpicks, otherwise it's all good.
We try to always put a new line at the end of a file, this can be done automatically when you save your file in vscode if the Insert Final Newline option is activated.
estate/__manifest__.py
Outdated
| 'name': 'Estate', | ||
| 'version': '1.9', | ||
| 'category': 'Real Estate', | ||
| 'summary' : 'Manage your real estate properties', |
There was a problem hiding this comment.
Unwanted white space here
| 'summary' : 'Manage your real estate properties', | |
| 'summary': 'Manage your real estate properties', |
estate/models/estate_property.py
Outdated
| _name = 'estate.property' | ||
| _description = 'Estate Property' | ||
| name = fields.Char(string='Name', required=True) | ||
|
|
There was a problem hiding this comment.
Try to put the new line between the private attributes and the fields instead
| _name = 'estate.property' | |
| _description = 'Estate Property' | |
| name = fields.Char(string='Name', required=True) | |
| _name = 'estate.property' | |
| _description = 'Estate Property' | |
| name = fields.Char(string='Name', required=True) |
csan-odoo
left a comment
csan-odoo
left a comment
There was a problem hiding this comment.
Great work! Just a few minor nitpicks
.gitignore
Outdated
|
|
||
| # Pyre type checker | ||
| .pyre/ | ||
| ruff.toml |
There was a problem hiding this comment.
make sure to always leave an empty line at the end of every file
estate/models/__init__.py
Outdated
| from . import ( | ||
| estate_property, | ||
| estate_property_offer, | ||
| estate_property_tag, | ||
| estate_property_type, | ||
| ) |
There was a problem hiding this comment.
nitpick
| from . import ( | |
| estate_property, | |
| estate_property_offer, | |
| estate_property_tag, | |
| estate_property_type, | |
| ) | |
| from . import estate_property | |
| from . import estate_property_offer | |
| from . import estate_property_tag | |
| from . import estate_property_type |
estate/models/estate_property.py
Outdated
| @api.depends("offer_ids.price") | ||
| def _compute_best_offer(self): | ||
| for record in self: | ||
| record.best_offer = max(record.offer_ids.mapped("price"), default=0) |
There was a problem hiding this comment.
Here, if there are no offers, it will break. It’s safer to handle that case explicitly. For example:
| record.best_offer = max(record.offer_ids.mapped("price"), default=0) | |
| record.best_offer = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0 |
estate/models/estate_property.py
Outdated
| def _onchange_garden(self): | ||
| if not self.garden: | ||
| self.garden_area = 0 | ||
| self.garden_orientation = "" |
There was a problem hiding this comment.
Selection fields usually expects either one of the predefined selection keys or False. Assigning an empty string could lead to inconsistent behaviours or validation errors.
| self.garden_orientation = "" | |
| self.garden_orientation = False |
| copy=False, | ||
| ) | ||
|
|
||
| @api.depends("validity") |
There was a problem hiding this comment.
| @api.depends("validity") | |
| @api.depends("create_date", "validity") |
| <field name="res_model">estate.property.tag</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
| <field name="res_model">estate.property.type</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
Add SQL constraints to ensure prices are positive and names are unique. Implement a Python constraint to prevent selling prices below 90% of the expected price.
4 participants
No description provided.