Skip to content

Conversation

@THDES-odoo
Copy link

No description provided.

This module will be the basis of the Estate App
@robodoo
Copy link

robodoo commented Jan 19, 2026

Pull request status dashboard

Copy link

@artn-odoo artn-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job so far !
All comments are small styling nitpicks but your code won't pass the styling tests if they are not fixed.
We also try to always add an empty line at the end of every file. If using vscode, the Insert Final Newline option can be activated to do it automatically every time you save your file.

Copy link

@artn-odoo artn-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, as usual just a few nitpicks

Comment on lines 12 to 13
date_availability = fields.Date('Availability Date', copy=False,
default=fields.Date.add(fields.Date.today(), months=3))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the line is split because it's too long, every parameter should be on it's own line

Suggested change
date_availability = fields.Date('Availability Date', copy=False,
default=fields.Date.add(fields.Date.today(), months=3))
date_availability = fields.Date(
'Availability Date',
copy=False,
default=fields.Date.add(fields.Date.today(), months=3)
)

And the closing bracket's indentation should match the opening one

Comment on lines 24 to 29
garden_orientation = fields.Selection(
string='Garden Orientation',
selection=[
('north', 'North'), ('south', 'South'),
('east', 'East'), ('west', 'West')
])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to match the opening bracket's indentation

Suggested change
garden_orientation = fields.Selection(
string='Garden Orientation',
selection=[
('north', 'North'), ('south', 'South'),
('east', 'East'), ('west', 'West')
])
garden_orientation = fields.Selection(
string='Garden Orientation',
selection=[
('north', 'North'),
('south', 'South'),
('east', 'East'),
('west', 'West')
]
)

Also, it would be better to have each selection proposition on it's own line

Comment on lines 33 to 39
selection=[
('new', 'New'), ('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'), ('cancelled', 'Cancelled') ],
default='new',
required=True
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Suggested change
selection=[
('new', 'New'), ('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'), ('cancelled', 'Cancelled') ],
default='new',
required=True
)
selection=[
('new', 'New'),
('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'),
('cancelled', 'Cancelled')
],
default='new',
required=True
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants