training-tupan #1124
Open
training-tupan #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TudorCalinCS
force-pushed
the
19.0-training-tupan
branch
from
2ee5a6f to
52a1b26
Compare
plha-odoo
reviewed
Jan 20, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
Good job for the general quality and readability of the code !
A few comments :
- We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline. - for the commit message and title we try to always follow these guidelines https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
- a few styling modifications for which I made local reviews (spaces arround an '=' except when used to define a parameter, spaces after but not before a ':', etc)
plha-odoo
reviewed
Jan 21, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
Good job for these chapters, for the applying the correct styling almost everywhere and for udpating the code after the first review.
Just a few comments :
- don't forget to use the proper git commit title convention event if it's an udpate, in which case your title should start with [FIX]
- two styling for which I did local reviews
Co-authored-by: plha-odoo <plha@odoo.com>
Co-authored-by: plha-odoo <plha@odoo.com>
Co-authored-by: plha-odoo <plha@odoo.com>
Complete chapter 8 Fix naming for view fiels (estate_views.xml -> estate_view.xml) Remove unsupported '_sql_constraints' from estate_property model Add missing author and license keys in manifest to remove the warnings
TudorCalinCS
force-pushed
the
19.0-training-tupan
branch
from
eff76ae to
98144b2
Compare
Author
|
Performed a rebase to align commit history with git guidelines. |
…perties (CHAPTER 9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.