[REF] machine_tool_rental: extract invoicing feature into new module#1660
Draft
[REF] machine_tool_rental: extract invoicing feature into new module#1660
Conversation
Collaborator
|
|
trcazier
force-pushed
the
19.0-recurring-rental-billing-trcaz
branch
2 times, most recently
from
c330315 to
5e16a05
Compare
This commit extracts the custom recurring rental billing features into a new module `recurring_rental_billing` to allow other industries to import and benefit from it. task-5478089
trcazier
force-pushed
the
19.0-recurring-rental-billing-trcaz
branch
from
5e16a05 to
fb1ab53
Compare
vava-odoo
approved these changes
Mar 2, 2026
Collaborator
vava-odoo
left a comment
vava-odoo
left a comment
There was a problem hiding this comment.
tiny remark + questions for you or Pierre
| ], | ||
| 'license': 'OEEL-1', | ||
| 'images': ['images/main.png'], | ||
| 'url': "https://www.odoo.com/trial?industry&selected_app=machine_tool_rental", |
Collaborator
There was a problem hiding this comment.
Suggested change
| 'url': "https://www.odoo.com/trial?industry&selected_app=machine_tool_rental", |
| <record id="stock_model_stock_storage_category_x_serial_status_field" model="ir.model.fields"> | ||
| <field name="ttype">selection</field> | ||
| <field name="copied" eval="True"/> | ||
| <field name="field_description">Serial Status</field> |
Collaborator
There was a problem hiding this comment.
I wonder why this field is here. Shouldn't it be in the other sub-module? (real question)
Contributor
Author
There was a problem hiding this comment.
Talked with SAVP and he agrees. I'll move this to the other submodule
| <field name="priority">99</field> | ||
| <field name="type">form</field> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='max_weight']/.." position="after"> |
Collaborator
There was a problem hiding this comment.
same question for the views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extracts the custom recurring rental billing features into a new module
recurring_rental_billingto allow other industries to import and benefit from it.task-5478089