[FIX] *: no more button_immediate_install call#1534
Open
[FIX] *: no more button_immediate_install call#1534
Conversation
Before this commit, we use button_immediate_install for payment_demo in order not to force the dependency while this module is only useful in demo mode. The problem is that button_immediate_install is not safe, as it creates issues in the registry, and therefore should be prevented. This commit replaces button_immediate_install by button_install, marking this module as "to be installed" (when the registry is loaded again). task-4804947
Collaborator
|
|
Contributor
|
@vava-odoo PR is good to go! 👍 |
Collaborator
Author
Thanks @pgu-odoo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, we use button_immediate_install for payment_demo in order not to force the dependency while this module is only useful in demo mode. The problem is that button_immediate_install is not safe, as it creates issues in the registry, and therefore should be prevented.
This commit replaces button_immediate_install by button_install, marking this module as "to be installed" (when the registry is loaded again).
task-4804947