Skip to content

Conversation

@huisit
Copy link

@huisit huisit commented Dec 15, 2025

added new article in accounting/payments/pay_direct_deposit, 200 lines

other:

  • added doc title to toc in accounting/payments.rst, ln 409. updated toctree order:
    1. pay with sepa
    2. NEW: pay by direct deposit
    3. pay by checks

This 19.0 PR can be FWP up to master.

@huisit huisit requested a review from Felicious December 15, 2025 23:22
@huisit huisit self-assigned this Dec 15, 2025
@robodoo
Copy link
Collaborator

robodoo commented Dec 15, 2025

Pull request status dashboard

@huisit
Copy link
Author

huisit commented Dec 15, 2025

@Felicious this is ready for review, pending ci/documentation!

@C3POdoo C3POdoo requested a review from a team December 15, 2025 23:40
@huisit
Copy link
Author

huisit commented Dec 15, 2025

to edit

  • line 15: remove comment in italics
  • line 26: click ​sign-up​ to create an account
  • ​​​​line 35: Link your Bbank Aaccount to your Wise account
  • line 38: ... link the company/source bank account ...
  • line 80: space before hyphen
  • general: replace API with |API| substitution role

questions

  • line 136/137: is it more appropriate to put the comment on the same line with a colon? i followed reference guide style (indent below), but it doesn't look as natural with a list in the admonition block
  • general: accounting/vendor bills not working when linked as :doc:`../vendor_bills` ... @nikibrown help
    • exact terminal output: /home/odoo/github/odoo/documentation/content/applications/finance/accounting/payments/pay_direct_deposit.rst:159: WARNING: undefined label: accounting/vendor-bills

@Felicious Felicious added the 5 label Dec 16, 2025
@huisit huisit force-pushed the 19.0-accounting-wise-direct-deposit-rexhu branch from 65b1602 to 3889a5b Compare December 16, 2025 03:22
@huisit
Copy link
Author

huisit commented Dec 16, 2025

@odoo/accounting-doc-review hello! We're adding this new Pay by direct deposit article for the US accounting localization with Wise, and are thinking of placing the article in between the existing Pay with SEPA and Pay by check articles.

Does this order make sense? If not, we'll swap it per your suggestion before merging.

@dade-odoo
Copy link
Contributor

Hi @huisit ! Thanks for the contribution :) Sorry to respond to your simple question about where to place this document with more complicated feedback, but here are my thoughts:

  1. As you said, this is relevant for the US localization, not so much for other localizations, so it makes more sense to put it in the US localization page instead of here alongside other more widespread payment methods. As is, it would be a pretty long addition to the existing localization page, but the next few points should help shorten it a bit.
  2. We want to refer to other existing pages wherever possible instead of repeating information. This makes it easier for us to update the information in one place instead of having to track down every place where we've explained how to do something (like create a batch payment) and change it everywhere if something changes in the future. You did a nice job of this with the see also link to the Bill creation page, but an even cleaner way to do it would be something like this:

After configuring direct deposit in both Wise and Odoo, create vendor bills and pay them using direct deposit. Select U.S. Direct Deposit as the Payment Method, and create a batch payment.

  1. Group the Wise and Odoo configuration sections under a single "Configuration" header ("Wise configuration" and "Odoo configuration" and everything that falls underneath them would shift down one header level).
  2. This page is similar structurally to some online payment provider pages such as Adyen and Razorpay - use those for inspiration and consider creating a numbered list of steps instead of the narrative flow as it would be easier to follow.
  3. The FAQ/Troubleshooting section can be removed and those items can be spread out:
  • Testing environment can be included as a tip at the end of the configuration section.
  • Cancel a batch payment can be the last item in the Pay vendor bills with direct deposit section. I haven't tested this, but the instructions seem a bit confusing to me:

Select the batch payment to cancel, click View Batch, and then click Cancel batch in Wise.

Is "in Wise" supposed to be part of the guilabel? Or do you actually have to go to the Wise portal and click "Cancel batch" there?

Doing all this should make the material a bit more condensed and then it could fit more easily on the US localization page.

@Felicious I know you already reviewed this and I might be stepping on your toes a bit here, but we don't want this as a separate doc page if it only applies to one localization. I have asked the POs if it's useful for others also and haven't heard back yet. Feel free to reach out either here or on Discord to discuss this in more detail! Thanks :)

@nikibrown
Copy link
Contributor

questions

  • line 136/137: is it more appropriate to put the comment on the same line with a colon? i followed reference guide style (indent below), but it doesn't look as natural with a list in the admonition block

  • general: accounting/vendor bills not working when linked as :doc:`../vendor_bills` ... @nikibrown help

    • exact terminal output: /home/odoo/github/odoo/documentation/content/applications/finance/accounting/payments/pay_direct_deposit.rst:159: WARNING: undefined label: accounting/vendor-bills

Sounds like you want to use doc

:doc:`Vendor Bills <../vendor_bills>`

Co-authored-by: Felicia Kuan <feku@odoo.com>
@huisit huisit force-pushed the 19.0-accounting-wise-direct-deposit-rexhu branch from 3889a5b to 317fc70 Compare December 17, 2025 02:31
@C3POdoo C3POdoo requested a review from a team December 17, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants