Enhance Authenticated User State Tests#297
Open
Chinex-Boroja wants to merge 5 commits intoodk-x:upgrade-jdk11from
Open
Enhance Authenticated User State Tests#297Chinex-Boroja wants to merge 5 commits intoodk-x:upgrade-jdk11from
Chinex-Boroja wants to merge 5 commits intoodk-x:upgrade-jdk11from
Conversation
… verification tests
Member
|
@Chinex-Boroja since an authenticated user has roles and groups it would be good to write additional tests that test the values are correctly set to standard groups and roles. Check out https://docs.odk-x.org/data-permission-filters/ for more information |
…e-authenticated-user-tests
…e-authenticated-user-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview/Summary
This PR enhances the test coverage for the AuthenticatedUserStateTest class by adding additional test cases to verify various properties related to authenticated user states. The following tests have been added:
verifyPasswordProperty: Verifies that the password property is correctly set and matches the expected value.verifyDefaultGroupProperty: Ensures that the default group property is correctly set and matches the expected default value.verifyRolesListProperty: Confirms that the roles list property is correctly set and matches the expected default value.verifyUsersListProperty: Ensures that the users list property is correctly set and matches the expected default value.verifyLastSyncInfoProperty: Checks that the last sync info property is initially null.verifyAuthenticationTypeProperty: Verifies that the authentication type property is correctly set and matches the expected value.verifyInvalidUserState: Tests that setting an invalid user state throws an IllegalArgumentException.verifyResetProperties: Ensures that properties are reset correctly using StaticStateManipulator.verifyAllProperties: Verifies all properties to ensure they are set correctly and match the expected values.