WIP: Add and fix warnings in CMake build system - #544
Conversation
merge opt flag branch for common library
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 47.86% 47.80% -0.07%
==========================================
Files 95 95
Lines 7673 7658 -15
Branches 669 671 +2
==========================================
- Hits 3673 3661 -12
+ Misses 3808 3805 -3
Partials 192 192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi Mahir, I can see this is a draft, but I noticed it includes changes from other PRs that haven't been merged into master yet. |
MahirAbbas
changed the title
Ohisemega
left a comment
Ohisemega
left a comment
There was a problem hiding this comment.
The interface format you have used doesn't seem to propagate the flags you want it to. This is an older method, but adding this CMAKE instruction to the frameProcessor's and frameReceiver's src CMakeLists produces the expected errors and warnings.
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -Wall -Wextra -Wpedantic")
|
N.B. this PR also introduces the Ninja build system and uses ccache which was instrumental in speeding up the recompile times. Can be removed if unwanted. |
| "workspaceMount": "source=${localWorkspaceFolder}/..,target=/workspaces,type=bind", | ||
| "mounts": [ | ||
| // Mount /dev/shm for odin-data applications to use | ||
| "source=odin-data-build,target=/workspaces/odin-data/vscode_build,type=volume", |
There was a problem hiding this comment.
The vscode_build volume will be removed from final PR
It would be better to have this in another PR. The code_format_check is also failing. |
There was a problem hiding this comment.
This file needs to be removed
There was a problem hiding this comment.
Do we want ninja-build and ccache
| @@ -29,6 +29,9 @@ | |||
| ] | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
do we want ccache
There was a problem hiding this comment.
do we want Ninja and ccache
2 participants
Fixes #547
N.B. this PR also introduces the Ninja build system and uses ccache which was instrumental in speeding up the recompile times. Can be removed if unwanted.