Repository navigation
Let a browser hand a geo link to the app - #107
Merged
Merged
Conversation
The geo filter had no BROWSABLE category, so another app's "open location" reached the app but a geo link tapped in a web page did not: a browser offers only activities that say they are browsable. Play Console's deep link check reported it as a broken link for the same reason. ArrivalTest's launches name the activity, so none of them touched the filters. A new test asks the package manager what a browser would reach for each link the app takes, the site's and a geo URI. Against the old manifest it fails on the geo link with an empty list; with the category it passes, with the other twelve arrival tests. The phone's version code goes to 2, since Play already holds 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Play Console's Deep links page reports
geo://as not working: "BROWSABLE category attribute failed". The geo filter hadVIEWandDEFAULTbut notBROWSABLE, so another app's "open location" reached the app while a geo link tapped in a web page did not. A browser offers only activities that say they are browsable.android.intent.category.BROWSABLE. The site's verifiedhttpsfilter already had it.ArrivalTest.aBrowserCanHandEachLinkToTheAppasks the package manager what a browser would reach for the site's link and for a geo URI. The existing arrival tests name the activity, so none of them touched the filters. Against the old manifest it fails on the geo link (expected [MainActivity] but was []); with the fix, all 13 arrival tests pass on the gpc36 emulator (API 36).lintDebugandaudit/assetlinks.pypass.