Repository navigation
Draw the feature graphic as the format itself - #104
Merged
Merged
Conversation
Play asks for a feature graphic that extends the icon rather than repeats it, on a ground that does not vanish into the store's white, and that says what the app is for. The old one was the icon's four bars on the page's near-white ground. The new one is how a code works: every character names one of 25 parts of the cell before it, five by five. Three cells are drawn cut into their parts, each lighting the part the next is drawn from, down to one doorway in brass. The parts lit are the ones St. Lawrence Market's north door, #G3RJM-8X3L1, is drawn from, as the reference implementation places them. It keeps the icon's four tints, level one as the ground and levels four, seven and ten as the cells, and has no words. Play's play button, laid over the centre when the listing's video does not play by itself, falls on the middle cell. It is still drawn by design/build-icons.mjs from the tokens, with no image library, and --check still compares it byte for byte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new feature graphic for the Play listing, still drawn by
design/build-icons.mjsfrom the tokens.Why
Play's guidance for the feature graphic asks for three things the old one missed:
The graphic is also the cover of the listing's video. When the video doesn't play by itself, Play lays its play button over the centre, which was on the bars.
What it shows
How a code works. Every character names one of 25 parts of the cell before it, five by five, so a code is a place inside a place.
#G3RJM-8X3L1, the place in the listing's screenshots: its3,Land1, as the reference implementation places them.Verified
node design/build-icons.mjs --check: 20 icons matchdesign/tokens.json. The output is deterministic, and CI compares it byte for byte.audit/markdown.pypasses.PLAY.md's graphics table describes the new graphic.