Repository navigation
Take the 7-inch tablet screenshots, and lay the search list over the map's buttons - #102
Merged
Merged
Conversation
…map's buttons Play's listing asks for 7-inch tablet screenshots as well as 10-inch ones. The four in play/screenshots/tablet-7 show the same screens as the 10-inch set, at 1920 by 1080 drawn at 1067 by 600 dp, the size a 7-inch tablet on its side lays the app out at. The 10-inch set moves to tablet-10, so each folder names the section it goes in. Taking them showed a fault the taller screen hid: on a screen 600 dp tall, the places a name could mean reach down past the map's zoom buttons, and the buttons drew on top of the list. The search box now lies above them. A new design check draws the wide layout at a 7-inch tablet's size, with and without a list open; before the fix it shows the buttons over the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Play's listing asks for 7-inch tablet screenshots as well as 10-inch ones. Taking them turned up a layout fault on short screens, fixed here.
Screenshots
android/play/screenshots/tablet-7(new, 4)android/play/screenshots/tablet-10(wastablet, unchanged)The 7-inch set shows the same four screens as the 10-inch one: a place, search by name beside the map, the short form anchored, and the dark theme over its night basemap. All are 24-bit PNG with no alpha.
PLAY.mdnow lists both sets and the density each was taken at.The fix
On a screen 600 dp tall, the places a name could mean reach down past the map's zoom buttons, and the buttons were drawn on top of the list. The 10-inch screen's extra height had hidden this.
zIndex), so the list covers them. Keyboard order and screen-reader order are unchanged.SmallTabletScreensTest, draws the wide layout at a 7-inch tablet's size (960 × 600 dp), with and without a list open. Recorded before the fix, it showed the + and − buttons over the list; after the fix, the list covers them.Verified
audit/markdown.pypasses.