Repository navigation
Fix non-reorderable table display order after topology changes - #9572
Closed
Anujgiri1279 wants to merge 3 commits into
Closed
Anujgiri1279 wants to merge 3 commits into
Anujgiri1279 wants to merge 3 commits into
Conversation
Co-authored-by: Anujgiri1279 <122677344+Anujgiri1279@users.noreply.github.com>
…ble-display-order Tables: reset non-reorderable display order in `TableFixDisplayOrder()`
Owner
|
Hello, Thanks for your PR.
The fix may or not be wrong, I don't know yet. But that's not an acceptable statement. Don't let Copilot state stupid things and submit that as PR. Use common sense. |
Author
Yeah , Okay Understood |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9570
Non-reorderable tables could display columns in the wrong order after columns were inserted or appended. Stale or duplicate
DisplayOrdervalues from table reconciliation and settings loading were being sorted even though non-reorderable tables should always follow declaration order.Changes
DisplayOrderto the column index for non-reorderable tables.DisplayOrderToIndexto match that order.The change is limited to
imgui_tables.cpp, insideImGui::TableFixDisplayOrder().Validation
examples/example_nullsuccessfully.example_nullsuccessfully through 20 frames.WITH_EXTRA_WARNINGS=1successfully.