Add support for ppxlib 0.23.0#2
Conversation
|
Update: Ignore this comment :) As pointed out below, it's wrong. Thanks for the fix, @kit-ty-kate! I was thinking if it would make sense to add a In general (also for unpublished packages), if the package is based on new ppxlib it should be able to use Also, @thierry-martinez, I've seen that 5 out of the 6 opam package I've mentioned above are yours: does it sound right to you what I've said about them? |
|
I was under the impression that |
|
Oh ok, thanks for pointing that out @kit-ty-kate, sorry for that! |
| | Ldot (Lident "Location", "t") -> "location" | ||
| | Ldot (Lident "Longident", "t") -> "longident" | ||
| | Ldot (Lident "Location", "t") (* ppxlib < 0.23.0 *) | ||
| | Ldot (Ldot (Lident "Astlib__", "Location"), "t") -> (* ppxlib >= 0.23.0 *) |
There was a problem hiding this comment.
By any chance, is it possible to use the public path to Location, so Ppxlib_astlib.Location.t , instead of the private one, i.e. Astlib__.Location.t, here? And in case that's possible, same for Longident below.
|
The ppxlib version @kit-ty-kate has mentioned above 0.23.0 has been released now. So for this metaquot extension to stay compatible with new ppxlib versions, it would be great to address this PR now. |
ppxlib will come without OMP starting with ppxlib.0.23.0.
A few changes were needed to match the new module location with what metaquot expects.
cc @pitag-ha