chore: don't pin packages for OxCaml opam tests#14286
Merged
Conversation
Signed-off-by: Shon Feder <shon.feder@gmail.com>
shonfeder
force-pushed
the
shonfeder/no-pin-for-oxcaml-tests
branch
from
5e37b1d to
044e529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14277
AFAIU, what we want to test in the
OxCaml Tests (opam)job is that we can build the dune codebase with oxcaml.However, the previous logic of the tests was also pinning all the packages in our repo. As a result of OxCaml now moving to enforce use of its select patched versions of dependencies, these pins were making the subsequent installation of dependencies unsatisfiable.
The simple solution proposed here was advise by @dra27 (thanks!): if we don't pin the packages in the repo, we don't introduce the conflicts. The test is then able to pass: https://github.com/ocaml/dune/actions/runs/24756394915/job/72430637518?pr=14286